Skip to content

fix: use new import.meta.webpackHmr to account for esm #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

edusperoni
Copy link
Collaborator

@edusperoni edusperoni commented Jan 16, 2022

PR Checklist

What is the current behavior?

Sometimes with angular 13 hmr will trigger a restart instead of a reload due to module['hot'] not being replaced by webpack.

What is the new behavior?

We use the new esm import.meta to get that information.

@cla-bot cla-bot bot added the cla: yes label Jan 16, 2022
@NathanWalker NathanWalker merged commit cd934e1 into main Jan 17, 2022
@NathanWalker NathanWalker deleted the fix/hmr-esm branch January 17, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants