fix: don't leak code cache data (#146)

edusperoni · web-flow · commit 17db0069ef16 · 2022-02-09T09:18:28.000-08:00
diff --git a/NativeScript/runtime/ModuleInternal.mm b/NativeScript/runtime/ModuleInternal.mm
@@ -422,11 +422,13 @@
     }
 
     Local<UnboundScript> unboundScript = script->GetUnboundScript();
+    // CachedData returned by this function should be owned by the caller (v8 docs)
     ScriptCompiler::CachedData* cachedData = ScriptCompiler::CreateCodeCache(unboundScript);
 
     int length = cachedData->length;
     std::string cachePath = GetCacheFileName(path + ".cache");
     tns::WriteBinary(cachePath, cachedData->data, length);
+    delete cachedData;
 }
 
 std::string ModuleInternal::GetCacheFileName(const std::string& path) {

Original file line number	Diff line number	Diff line change
`@@ -422,11 +422,13 @@`
`422`	`422`	`}`
`423`	`423`
`424`	`424`	`Local<UnboundScript> unboundScript = script->GetUnboundScript();`
	`425`	`+ // CachedData returned by this function should be owned by the caller (v8 docs)`
`425`	`426`	`ScriptCompiler::CachedData* cachedData = ScriptCompiler::CreateCodeCache(unboundScript);`
`426`	`427`
`427`	`428`	`int length = cachedData->length;`
`428`	`429`	`std::string cachePath = GetCacheFileName(path + ".cache");`
`429`	`430`	`tns::WriteBinary(cachePath, cachedData->data, length);`
	`431`	`+ delete cachedData;`
`430`	`432`	`}`
`431`	`433`
`432`	`434`	`std::string ModuleInternal::GetCacheFileName(const std::string& path) {`