Data Corruption caused by NS 8.1 PR #127

[NathanaelA]

@rigor789 @darind - There appears to be a corner case bug if the string passed in is "" (empty). Only occurs with NS 8.1 runtime, and we tracked it down to empty string being passed in. I figured out a work around in my case, but the issue is definitely something in the 8.1 runtime as 8.0 works great. My guess is the #127 here is causing the issue as it probably is NOT creating a null terminated 0 length string properly (i.e. the string I believe should technically be 1 character, a single null character).

[darind]

@NathanaelA, can you please provide a sample javascript illustrating the issue?

[darind]

@NathanaelA, #132 should address this issue.

[darind]

@NathanaelA, this PR adjusts the string length passed to v8’s ExternalString accounting for the null terminating character. So for example, the length of the empty string should be 1 instead of 0.

[NathanWalker]

Thanks @darind, #132 published in 8.2.0-alpha.0 - Upon confirmation this issue can be closed and will be included with 8.2 in coming weeks.