Skip to content

Commit 8f2ab06

Browse files
dg0ytJavier Matos
and
Javier Matos
authored
[vcpkg-make] Misc fixes (microsoft#42954)
Co-authored-by: Javier Matos <[email protected]>
1 parent 4b3b620 commit 8f2ab06

File tree

7 files changed

+37
-19
lines changed

7 files changed

+37
-19
lines changed

ports/vcpkg-make/portfile.cmake

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
set(VCPKG_POLICY_CMAKE_HELPER_PORT enabled)
22

3+
set(automake_version 1.17)
34
vcpkg_download_distfile(ARCHIVE
4-
URLS https://ftp.gnu.org/gnu/automake/automake-1.17.tar.gz
5-
FILENAME automake.tar.gz
5+
URLS https://ftp.gnu.org/gnu/automake/automake-${automake_version}.tar.gz
6+
https://www.mirrorservice.org/sites/ftp.gnu.org/gnu/automake/automake-${automake_version}.tar.gz
7+
FILENAME automake-${automake_version}.tar.gz
68
SHA512 11357dfab8cbf4b5d94d9d06e475732ca01df82bef1284888a34bd558afc37b1a239bed1b5eb18a9dbcc326344fb7b1b301f77bb8385131eb8e1e118b677883a
79
)
810

@@ -29,4 +31,13 @@ file(INSTALL
2931
"${CURRENT_PACKAGES_DIR}/share/${PORT}/wrappers"
3032
)
3133

32-
vcpkg_install_copyright(FILE_LIST "${VCPKG_ROOT_DIR}/LICENSE.txt")
34+
vcpkg_install_copyright(
35+
COMMENT [[
36+
The cmake scripts are under vcpkg's MIT license terms, see LICENSE.txt below.
37+
The port also installs shell scripts from GNU Automake.
38+
These scripts are under GPL-2.0-or-later, see COPYING below.
39+
]]
40+
FILE_LIST
41+
"${VCPKG_ROOT_DIR}/LICENSE.txt"
42+
"${automake_source}/COPYING"
43+
)

ports/vcpkg-make/vcpkg.json

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
{
22
"name": "vcpkg-make",
3-
"version-date": "2023-05-15",
4-
"documentation": "https://vcpkg.io/en/docs/maintainers/ports/vcpkg-make.html",
5-
"license": "MIT",
3+
"version-date": "2024-12-27",
4+
"documentation": "https://learn.microsoft.com/vcpkg/maintainers/functions/vcpkg_make_configure",
5+
"license": null,
66
"supports": "native",
77
"dependencies": [
88
{
9-
"name": "pkgconf",
10-
"host": true,
11-
"platform": "windows"
12-
},
13-
"vcpkg-cmake-get-vars"
9+
"name": "vcpkg-cmake-get-vars",
10+
"host": true
11+
}
1412
]
1513
}

ports/vcpkg-make/vcpkg_make_common.cmake

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ function(z_vcpkg_make_determine_arch out_var value)
5252
elseif(${value} MATCHES "^(ARM|arm)$")
5353
set(${out_var} arm PARENT_SCOPE)
5454
elseif(${value} MATCHES "^(x86_64|i686|aarch64)$" OR NOT VCPKG_TARGET_IS_WINDOWS)
55-
# Do nothing an assume valid architectures
55+
# Do nothing and assume valid architecture
5656
set("${out_var}" "${value}" PARENT_SCOPE)
5757
else()
5858
message(FATAL_ERROR "Unsupported architecture '${value}' in '${CMAKE_CURRENT_FUNCTION}'!" )
@@ -65,6 +65,7 @@ function(z_vcpkg_make_determine_host_arch out_var)
6565
elseif(DEFINED ENV{PROCESSOR_ARCHITECTURE})
6666
set(arch $ENV{PROCESSOR_ARCHITECTURE})
6767
else()
68+
z_vcpkg_make_get_cmake_vars(#[[ LANGUAGES .... ]])
6869
set(arch "${VCPKG_DETECTED_CMAKE_HOST_SYSTEM_PROCESSOR}")
6970
endif()
7071
z_vcpkg_make_determine_arch("${out_var}" "${arch}")
@@ -280,7 +281,7 @@ function(z_vcpkg_make_prepare_programs out_env)
280281
endif()
281282
endforeach()
282283

283-
if (NOT arg_DISABLE_MSVC_WRAPPERS)
284+
if (NOT arg_DISABLE_MSVC_WRAPPERS AND NOT VCPKG_TARGET_IS_MINGW)
284285
z_vcpkg_append_to_configure_environment(configure_env CPP "compile ${VCPKG_DETECTED_CMAKE_C_COMPILER} -E")
285286
z_vcpkg_append_to_configure_environment(configure_env CC "compile ${VCPKG_DETECTED_CMAKE_C_COMPILER}")
286287
z_vcpkg_append_to_configure_environment(configure_env CXX "compile ${VCPKG_DETECTED_CMAKE_CXX_COMPILER}")

ports/vcpkg-make/vcpkg_make_configure.cmake

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ function(vcpkg_make_configure)
3636
list(APPEND prepare_flags_opts "LANGUAGES" ${arg_LANGUAGES})
3737
endif()
3838

39+
# Create cached cmake vars for this invocation's languages
40+
z_vcpkg_make_get_cmake_vars(LANGUAGES ${arg_LANGUAGES})
41+
3942
set(escaping "")
4043
if(arg_DISABLE_MSVC_TRANSFORMATIONS)
4144
set(escaping NO_FLAG_ESCAPING)

ports/vcpkg-make/vcpkg_scripts.cmake

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -154,14 +154,14 @@ function(vcpkg_prepare_pkgconfig config)
154154
endforeach()
155155

156156
vcpkg_find_acquire_program(PKGCONFIG)
157-
get_filename_component(pkgconfig_path "${PKGCONFIG}" DIRECTORY)
158157
set(ENV{PKG_CONFIG} "${PKGCONFIG}")
159158

160159
vcpkg_host_path_list(PREPEND ENV{PKG_CONFIG_PATH}
161-
"${CURRENT_INSTALLED_DIR}/share/pkgconfig/"
162-
"${CURRENT_INSTALLED_DIR}${subdir}/lib/pkgconfig/"
163-
"${CURRENT_PACKAGES_DIR}/share/pkgconfig/"
164-
"${CURRENT_PACKAGES_DIR}${subdir}/lib/pkgconfig/"
160+
# After installation, (merged) 'lib' is always searched before 'share'.
161+
"${CURRENT_PACKAGES_DIR}${subdir}/lib/pkgconfig"
162+
"${CURRENT_INSTALLED_DIR}${subdir}/lib/pkgconfig"
163+
"${CURRENT_PACKAGES_DIR}/share/pkgconfig"
164+
"${CURRENT_INSTALLED_DIR}/share/pkgconfig"
165165
)
166166
endfunction()
167167

versions/baseline.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9401,7 +9401,7 @@
94019401
"port-version": 0
94029402
},
94039403
"vcpkg-make": {
9404-
"baseline": "2023-05-15",
9404+
"baseline": "2024-12-27",
94059405
"port-version": 0
94069406
},
94079407
"vcpkg-msbuild": {

versions/v-/vcpkg-make.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
{
22
"versions": [
3+
{
4+
"git-tree": "ac1381c26cff8ab8365670f4fb00395e86c58dfa",
5+
"version-date": "2024-12-27",
6+
"port-version": 0
7+
},
38
{
49
"git-tree": "50a2b6aaf3c272b1eff8ce757e14091c374d9855",
510
"version-date": "2023-05-15",

0 commit comments

Comments
 (0)