Skip to content

Commit 8b15b31

Browse files
committed
ParseXS: refactor: OUTPUT_handler() reindent.
This is #4 of a small series of commits to refactor the OUTPUT_handler() method and turn it into a Node subclass method. This commit reindents OUTPUT_handler() and OUTPUT_handler_line() from 2-indent to 4-indent to match the policy of the file they were moved to in the previous commit. Whitespace-only change
1 parent 414ef77 commit 8b15b31

File tree

1 file changed

+25
-26
lines changed
  • dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS

1 file changed

+25
-26
lines changed

dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Node.pm

Lines changed: 25 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -3041,18 +3041,18 @@ package ExtUtils::ParseXS; # XXX tmp
30413041
# Process the lines following the OUTPUT: keyword.
30423042

30433043
sub OUTPUT_handler {
3044-
my ExtUtils::ParseXS $self = shift;
3044+
my ExtUtils::ParseXS $self = shift;
30453045

3046-
my $line = shift;
3046+
my $line = shift;
30473047

3048-
# In this loop: process each line until the next keyword or end of
3049-
# paragraph
3048+
# In this loop: process each line until the next keyword or end of
3049+
# paragraph
30503050

3051-
for (; $line !~ /^$ExtUtils::ParseXS::BLOCK_regexp/o; $line = shift(@{ $self->{line} })) {
3052-
$self->OUTPUT_handler_line($line);
3053-
} # foreach line in OUTPUT block
3051+
for (; $line !~ /^$ExtUtils::ParseXS::BLOCK_regexp/o; $line = shift(@{ $self->{line} })) {
3052+
$self->OUTPUT_handler_line($line);
3053+
} # foreach line in OUTPUT block
30543054

3055-
$_ = $line;
3055+
$_ = $line;
30563056
}
30573057

30583058

@@ -3063,14 +3063,14 @@ package ExtUtils::ParseXS; # XXX tmp
30633063
# process a single line from an OUTPUT section
30643064

30653065
sub OUTPUT_handler_line {
3066-
my ExtUtils::ParseXS $self = shift;
3067-
my $line = shift;
3066+
my ExtUtils::ParseXS $self = shift;
3067+
my $line = shift;
30683068

30693069
return unless $line =~ /\S/; # skip blank lines
30703070

30713071
if ($line =~ /^\s*SETMAGIC\s*:\s*(ENABLE|DISABLE)\s*/) {
3072-
$self->{xsub_SETMAGIC_state} = ($1 eq "ENABLE" ? 1 : 0);
3073-
return;
3072+
$self->{xsub_SETMAGIC_state} = ($1 eq "ENABLE" ? 1 : 0);
3073+
return;
30743074
}
30753075

30763076
# Expect lines of the two forms
@@ -3083,34 +3083,33 @@ sub OUTPUT_handler_line {
30833083
$self->{xsub_sig}{names}{$outarg};
30843084

30853085
if ($param && $param->{in_output}) {
3086-
$self->blurt("Error: duplicate OUTPUT parameter '$outarg' ignored");
3087-
return;
3086+
$self->blurt("Error: duplicate OUTPUT parameter '$outarg' ignored");
3087+
return;
30883088
}
30893089

30903090
if ($outarg eq "RETVAL" and $self->{xsub_seen_NO_OUTPUT}) {
3091-
$self->blurt("Error: can't use RETVAL in OUTPUT when NO_OUTPUT declared");
3092-
return;
3091+
$self->blurt("Error: can't use RETVAL in OUTPUT when NO_OUTPUT declared");
3092+
return;
30933093
}
30943094

30953095
if ( !$param # no such param or, for RETVAL, RETVAL was void
3096-
# not bound to an arg which can be updated
3097-
or $outarg ne "RETVAL" && !$param->{arg_num})
3096+
# not bound to an arg which can be updated
3097+
or $outarg ne "RETVAL" && !$param->{arg_num})
30983098
{
3099-
$self->blurt("Error: OUTPUT $outarg not a parameter");
3100-
return;
3099+
$self->blurt("Error: OUTPUT $outarg not a parameter");
3100+
return;
31013101
}
31023102

3103-
31043103
$param->{in_output} = 1;
31053104
$param->{do_setmagic} = $outarg eq 'RETVAL'
3106-
? 0 # RETVAL never needs magic setting
3107-
: $self->{xsub_SETMAGIC_state};
3105+
? 0 # RETVAL never needs magic setting
3106+
: $self->{xsub_SETMAGIC_state};
31083107
$param->{output_code} = $outcode if length $outcode;
31093108

31103109
if ($outarg eq 'RETVAL') {
3111-
# Postpone processing the RETVAL line to last (it's left to the
3112-
# caller to finish).
3113-
return;
3110+
# Postpone processing the RETVAL line to last (it's left to the
3111+
# caller to finish).
3112+
return;
31143113
}
31153114

31163115
$param->as_output_code($self);

0 commit comments

Comments
 (0)