Skip to content

Commit ebd9562

Browse files
committed
checkAUTHORS.pl - delete and replace with updateAUTHORS.pl
updateAUTHORS.pl now can replace all the capabilities of checkAUTHORS.pl, and checkAUTHORS.pl has a slightly different idea of what needs to be validated, and is not aware of the Porting/exclude_contrib.txt. Instead of teaching it to be aware and maintaining two tools this drops checkAUTHORS.pl In the process we move the logic for t/porting/pending-author.t into t/porting/authors.t, by letting updateAUTHORS.pl do it as well. This is helpful because updateAUTHORS.pl contains similar core git logic so that it can implement some of its options.
1 parent 514f2db commit ebd9562

File tree

9 files changed

+7
-1381
lines changed

9 files changed

+7
-1381
lines changed

MANIFEST

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5387,7 +5387,6 @@ Porting/bisect-runner.pl Tool to be called by git bisect run
53875387
Porting/bump-perl-version bump the perl version in relevant files
53885388
Porting/check-cpan-pollution Check for commits that may wrongly touch CPAN distros
53895389
Porting/checkansi.pl Check source code for ANSI-C violations
5390-
Porting/checkAUTHORS.pl Check that the AUTHORS file is complete
53915390
Porting/checkcfguse.pl Check that config symbols are being used
53925391
Porting/checkcfgvar.pl Check that config scripts define all symbols
53935392
Porting/checkpodencoding.pl Check POD encoding
@@ -6075,7 +6074,6 @@ t/porting/known_pod_issues.dat Data file for porting/podcheck.t
60756074
t/porting/libperl.t Check libperl.a sanity
60766075
t/porting/maintainers.t Test that Porting/Maintainers.pl is up to date
60776076
t/porting/manifest.t Test that this MANIFEST file is well formed
6078-
t/porting/pending-author.t Check if any pending commit would break tests
60796077
t/porting/perlfunc.t Test that Functions_pm.PL can parse perlfunc.pod
60806078
t/porting/pod_rules.t Check that various pod lists are consistent
60816079
t/porting/podcheck.t Test the POD of shipped modules is well formed

Porting/README.pod

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,6 @@ number in various files within the perl source.
3737

3838
Check source code for ANSI-C violations.
3939

40-
=head2 F<checkAUTHORS.pl>
41-
42-
Used by F<t/porting/authors.t> to ensure the F<AUTHORS> list is up to
43-
date. See also L<< /"F<updateAUTHORS.pl>" >> for a way to automatically
44-
fix issues found by this tool.
45-
4640
=head2 F<checkcfguse.pl>
4741

4842
Check where the symbols defined in the various F<config.sh>-clones

Porting/acknowledgements.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,5 +163,5 @@ sub commify {
163163
# returns a list of the authors
164164
sub authors {
165165
return
166-
qx(git log --pretty=fuller $since_until | $^X Porting/checkAUTHORS.pl --who -);
166+
qx($^X Porting/updateAUTHORS.pl --who $since_until);
167167
}

0 commit comments

Comments
 (0)