Skip to content

Commit cac21f6

Browse files
ericspodpre-commit-ci[bot]KumoLiu
authored
Cleaning up some very old and now obsolete infrastructure (#8113)
### Description This removes some functions which aren't needed any more. These related to an early idea for doing importation to avoid defining `__all__` components to modules, but this is being done instead as it is more standard. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Eric Kerfoot <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: YunLiu <[email protected]>
1 parent acfc508 commit cac21f6

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+90
-307
lines changed

docs/source/networks.rst

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -735,14 +735,9 @@ Nets
735735
.. autoclass:: VoxelMorphUNet
736736
:members:
737737

738-
.. autoclass:: voxelmorphunet
739-
:members:
740-
741738
.. autoclass:: VoxelMorph
742739
:members:
743740

744-
.. autoclass:: voxelmorph
745-
746741
Utilities
747742
---------
748743
.. automodule:: monai.networks.utils

docs/source/utils.rst

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,6 @@ Module utils
1717
:members:
1818

1919

20-
Aliases
21-
-------
22-
.. automodule:: monai.utils.aliases
23-
:members:
24-
25-
2620
Misc
2721
----
2822
.. automodule:: monai.utils.misc

monai/__init__.py

Lines changed: 18 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -79,28 +79,25 @@ def filter(self, record):
7979
category=RuntimeWarning,
8080
)
8181

82-
from .utils.module import load_submodules # noqa: E402
83-
84-
# handlers_* have some external decorators the users may not have installed
85-
# *.so files and folder "_C" may not exist when the cpp extensions are not compiled
86-
excludes = "|".join(
87-
[
88-
"(^(monai.handlers))",
89-
"(^(monai.bundle))",
90-
"(^(monai.fl))",
91-
"((\\.so)$)",
92-
"(^(monai._C))",
93-
"(.*(__main__)$)",
94-
"(.*(video_dataset)$)",
95-
"(.*(nnunet).*$)",
96-
]
97-
)
98-
99-
# load directory modules only, skip loading individual files
100-
load_submodules(sys.modules[__name__], False, exclude_pattern=excludes)
10182

102-
# load all modules, this will trigger all export decorations
103-
load_submodules(sys.modules[__name__], True, exclude_pattern=excludes)
83+
from . import ( # noqa: E402
84+
apps,
85+
auto3dseg,
86+
bundle,
87+
config,
88+
data,
89+
engines,
90+
fl,
91+
handlers,
92+
inferers,
93+
losses,
94+
metrics,
95+
networks,
96+
optimizers,
97+
transforms,
98+
utils,
99+
visualize,
100+
)
104101

105102
__all__ = [
106103
"apps",

monai/bundle/scripts.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
from monai.bundle.config_parser import ConfigParser
3535
from monai.bundle.utils import DEFAULT_INFERENCE, DEFAULT_METADATA, merge_kv
3636
from monai.bundle.workflows import BundleWorkflow, ConfigWorkflow
37-
from monai.config import IgniteInfo, PathLike
37+
from monai.config import PathLike
3838
from monai.data import load_net_with_metadata, save_net_with_metadata
3939
from monai.networks import (
4040
convert_to_onnx,
@@ -45,6 +45,7 @@
4545
save_state,
4646
)
4747
from monai.utils import (
48+
IgniteInfo,
4849
check_parent_dir,
4950
deprecated_arg,
5051
ensure_tuple,

monai/config/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
from .deviceconfig import (
1515
USE_COMPILED,
1616
USE_META_DICT,
17-
IgniteInfo,
1817
get_config_values,
1918
get_gpu_info,
2019
get_optional_config_values,

monai/config/deviceconfig.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
"print_debug_info",
4646
"USE_COMPILED",
4747
"USE_META_DICT",
48-
"IgniteInfo",
4948
]
5049

5150

@@ -261,14 +260,5 @@ def print_debug_info(file: TextIO = sys.stdout) -> None:
261260
print_gpu_info(file)
262261

263262

264-
class IgniteInfo:
265-
"""
266-
Config information of the PyTorch ignite package.
267-
268-
"""
269-
270-
OPT_IMPORT_VERSION = "0.4.4"
271-
272-
273263
if __name__ == "__main__":
274264
print_debug_info()

monai/engines/evaluator.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@
1717
import torch
1818
from torch.utils.data import DataLoader
1919

20-
from monai.config import IgniteInfo, KeysCollection
20+
from monai.config import KeysCollection
2121
from monai.data import MetaTensor
2222
from monai.engines.utils import IterationEvents, default_metric_cmp_fn, default_prepare_batch
2323
from monai.engines.workflow import Workflow
2424
from monai.inferers import Inferer, SimpleInferer
2525
from monai.networks.utils import eval_mode, train_mode
2626
from monai.transforms import Transform
27-
from monai.utils import ForwardMode, ensure_tuple, min_version, optional_import
27+
from monai.utils import ForwardMode, IgniteInfo, ensure_tuple, min_version, optional_import
2828
from monai.utils.enums import CommonKeys as Keys
2929
from monai.utils.enums import EngineStatsKeys as ESKeys
3030
from monai.utils.module import look_up_option, pytorch_after

monai/engines/trainer.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,12 @@
1818
from torch.optim.optimizer import Optimizer
1919
from torch.utils.data import DataLoader
2020

21-
from monai.config import IgniteInfo
2221
from monai.data import MetaTensor
2322
from monai.engines.utils import IterationEvents, default_make_latent, default_metric_cmp_fn, default_prepare_batch
2423
from monai.engines.workflow import Workflow
2524
from monai.inferers import Inferer, SimpleInferer
2625
from monai.transforms import Transform
27-
from monai.utils import AdversarialIterationEvents, AdversarialKeys, GanKeys, min_version, optional_import
26+
from monai.utils import AdversarialIterationEvents, AdversarialKeys, GanKeys, IgniteInfo, min_version, optional_import
2827
from monai.utils.enums import CommonKeys as Keys
2928
from monai.utils.enums import EngineStatsKeys as ESKeys
3029
from monai.utils.module import pytorch_after

monai/engines/utils.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,8 @@
1818
import torch
1919
import torch.nn as nn
2020

21-
from monai.config import IgniteInfo
2221
from monai.transforms import apply_transform
23-
from monai.utils import ensure_tuple, min_version, optional_import
22+
from monai.utils import IgniteInfo, ensure_tuple, min_version, optional_import
2423
from monai.utils.enums import CommonKeys, GanKeys
2524

2625
if TYPE_CHECKING:

monai/engines/workflow.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,9 @@
2020
from torch.utils.data import DataLoader
2121
from torch.utils.data.distributed import DistributedSampler
2222

23-
from monai.config import IgniteInfo
2423
from monai.engines.utils import IterationEvents, default_metric_cmp_fn, default_prepare_batch
2524
from monai.transforms import Decollated
26-
from monai.utils import ensure_tuple, is_scalar, min_version, optional_import
25+
from monai.utils import IgniteInfo, ensure_tuple, is_scalar, min_version, optional_import
2726

2827
from .utils import engine_apply_transform
2928

monai/handlers/checkpoint_loader.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,8 @@
1717

1818
import torch
1919

20-
from monai.config import IgniteInfo
2120
from monai.networks.utils import copy_model_state
22-
from monai.utils import min_version, optional_import
21+
from monai.utils import IgniteInfo, min_version, optional_import
2322

2423
Events, _ = optional_import("ignite.engine", IgniteInfo.OPT_IMPORT_VERSION, min_version, "Events")
2524
Checkpoint, _ = optional_import("ignite.handlers", IgniteInfo.OPT_IMPORT_VERSION, min_version, "Checkpoint")

monai/handlers/checkpoint_saver.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@
1717
from collections.abc import Mapping
1818
from typing import TYPE_CHECKING, Any
1919

20-
from monai.config import IgniteInfo
21-
from monai.utils import is_scalar, min_version, optional_import
20+
from monai.utils import IgniteInfo, is_scalar, min_version, optional_import
2221

2322
Events, _ = optional_import("ignite.engine", IgniteInfo.OPT_IMPORT_VERSION, min_version, "Events")
2423

monai/handlers/classification_saver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818

1919
import torch
2020

21-
from monai.config import IgniteInfo
2221
from monai.data import CSVSaver, decollate_batch
22+
from monai.utils import IgniteInfo
2323
from monai.utils import ImageMetaKey as Key
2424
from monai.utils import evenly_divisible_all_gather, min_version, optional_import, string_list_all_gather
2525

monai/handlers/decollate_batch.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@
1313

1414
from typing import TYPE_CHECKING
1515

16-
from monai.config import IgniteInfo, KeysCollection
16+
from monai.config import KeysCollection
1717
from monai.engines.utils import IterationEvents
1818
from monai.transforms import Decollated
19-
from monai.utils import min_version, optional_import
19+
from monai.utils import IgniteInfo, min_version, optional_import
2020

2121
Events, _ = optional_import("ignite.engine", IgniteInfo.OPT_IMPORT_VERSION, min_version, "Events")
2222
if TYPE_CHECKING:

monai/handlers/earlystop_handler.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
from collections.abc import Callable
1515
from typing import TYPE_CHECKING
1616

17-
from monai.config import IgniteInfo
18-
from monai.utils import min_version, optional_import
17+
from monai.utils import IgniteInfo, min_version, optional_import
1918

2019
Events, _ = optional_import("ignite.engine", IgniteInfo.OPT_IMPORT_VERSION, min_version, "Events")
2120
EarlyStopping, _ = optional_import("ignite.handlers", IgniteInfo.OPT_IMPORT_VERSION, min_version, "EarlyStopping")

monai/handlers/garbage_collector.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
import gc
1515
from typing import TYPE_CHECKING
1616

17-
from monai.config import IgniteInfo
18-
from monai.utils import min_version, optional_import
17+
from monai.utils import IgniteInfo, min_version, optional_import
1918

2019
if TYPE_CHECKING:
2120
from ignite.engine import Engine, Events

monai/handlers/ignite_metric.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,8 @@
1818
import torch
1919
from torch.nn.modules.loss import _Loss
2020

21-
from monai.config import IgniteInfo
2221
from monai.metrics import CumulativeIterationMetric, LossMetric
23-
from monai.utils import MetricReduction, min_version, optional_import
22+
from monai.utils import IgniteInfo, MetricReduction, min_version, optional_import
2423

2524
idist, _ = optional_import("ignite", IgniteInfo.OPT_IMPORT_VERSION, min_version, "distributed")
2625

monai/handlers/logfile_handler.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@
1515
import os
1616
from typing import TYPE_CHECKING
1717

18-
from monai.config import IgniteInfo
19-
from monai.utils import min_version, optional_import
18+
from monai.utils import IgniteInfo, min_version, optional_import
2019

2120
Events, _ = optional_import("ignite.engine", IgniteInfo.OPT_IMPORT_VERSION, min_version, "Events")
2221
if TYPE_CHECKING:

monai/handlers/lr_schedule_handler.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@
1717

1818
from torch.optim.lr_scheduler import ReduceLROnPlateau, _LRScheduler
1919

20-
from monai.config import IgniteInfo
21-
from monai.utils import ensure_tuple, min_version, optional_import
20+
from monai.utils import IgniteInfo, ensure_tuple, min_version, optional_import
2221

2322
Events, _ = optional_import("ignite.engine", IgniteInfo.OPT_IMPORT_VERSION, min_version, "Events")
2423
if TYPE_CHECKING:

monai/handlers/metric_logger.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@
1717
from threading import RLock
1818
from typing import TYPE_CHECKING, Any
1919

20-
from monai.config import IgniteInfo
21-
from monai.utils import min_version, optional_import
20+
from monai.utils import IgniteInfo, min_version, optional_import
2221
from monai.utils.enums import CommonKeys
2322

2423
Events, _ = optional_import("ignite.engine", IgniteInfo.OPT_IMPORT_VERSION, min_version, "Events")

monai/handlers/metrics_saver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
from collections.abc import Callable, Sequence
1515
from typing import TYPE_CHECKING
1616

17-
from monai.config import IgniteInfo
1817
from monai.data import decollate_batch
1918
from monai.handlers.utils import write_metrics_reports
19+
from monai.utils import IgniteInfo
2020
from monai.utils import ImageMetaKey as Key
2121
from monai.utils import ensure_tuple, min_version, optional_import, string_list_all_gather
2222

monai/handlers/mlflow_handler.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222
from torch.utils.data import Dataset
2323

2424
from monai.apps.utils import get_logger
25-
from monai.config import IgniteInfo
26-
from monai.utils import CommonKeys, ensure_tuple, min_version, optional_import
25+
from monai.utils import CommonKeys, IgniteInfo, ensure_tuple, min_version, optional_import
2726

2827
Events, _ = optional_import("ignite.engine", IgniteInfo.OPT_IMPORT_VERSION, min_version, "Events")
2928
mlflow, _ = optional_import("mlflow", descriptor="Please install mlflow before using MLFlowHandler.")

monai/handlers/nvtx_handlers.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@
1616

1717
from typing import TYPE_CHECKING
1818

19-
from monai.config import IgniteInfo
20-
from monai.utils import ensure_tuple, min_version, optional_import
19+
from monai.utils import IgniteInfo, ensure_tuple, min_version, optional_import
2120

2221
_nvtx, _ = optional_import("torch._C._nvtx", descriptor="NVTX is not installed. Are you sure you have a CUDA build?")
2322
if TYPE_CHECKING:

monai/handlers/parameter_scheduler.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@
1616
from collections.abc import Callable
1717
from typing import TYPE_CHECKING
1818

19-
from monai.config import IgniteInfo
20-
from monai.utils import min_version, optional_import
19+
from monai.utils import IgniteInfo, min_version, optional_import
2120

2221
if TYPE_CHECKING:
2322
from ignite.engine import Engine, Events

monai/handlers/postprocessing.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,8 @@
1414
from collections.abc import Callable
1515
from typing import TYPE_CHECKING
1616

17-
from monai.config import IgniteInfo
1817
from monai.engines.utils import IterationEvents, engine_apply_transform
19-
from monai.utils import min_version, optional_import
18+
from monai.utils import IgniteInfo, min_version, optional_import
2019

2120
Events, _ = optional_import("ignite.engine", IgniteInfo.OPT_IMPORT_VERSION, min_version, "Events")
2221
if TYPE_CHECKING:

monai/handlers/probability_maps.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@
1717

1818
import numpy as np
1919

20-
from monai.config import DtypeLike, IgniteInfo
20+
from monai.config import DtypeLike
2121
from monai.data.folder_layout import FolderLayout
2222
from monai.utils import ProbMapKeys, min_version, optional_import
23-
from monai.utils.enums import CommonKeys
23+
from monai.utils.enums import CommonKeys, IgniteInfo
2424

2525
Events, _ = optional_import("ignite.engine", IgniteInfo.OPT_IMPORT_VERSION, min_version, "Events")
2626
if TYPE_CHECKING:

monai/handlers/smartcache_handler.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,8 @@
1313

1414
from typing import TYPE_CHECKING
1515

16-
from monai.config import IgniteInfo
1716
from monai.data import SmartCacheDataset
18-
from monai.utils import min_version, optional_import
17+
from monai.utils import IgniteInfo, min_version, optional_import
1918

2019
Events, _ = optional_import("ignite.engine", IgniteInfo.OPT_IMPORT_VERSION, min_version, "Events")
2120
if TYPE_CHECKING:

monai/handlers/stats_handler.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919
import torch
2020

2121
from monai.apps import get_logger
22-
from monai.config import IgniteInfo
23-
from monai.utils import is_scalar, min_version, optional_import
22+
from monai.utils import IgniteInfo, is_scalar, min_version, optional_import
2423

2524
Events, _ = optional_import("ignite.engine", IgniteInfo.OPT_IMPORT_VERSION, min_version, "Events")
2625
if TYPE_CHECKING:

monai/handlers/tensorboard_handlers.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@
1818
import numpy as np
1919
import torch
2020

21-
from monai.config import IgniteInfo
22-
from monai.utils import is_scalar, min_version, optional_import
21+
from monai.utils import IgniteInfo, is_scalar, min_version, optional_import
2322
from monai.visualize import plot_2d_or_3d_image
2423

2524
Events, _ = optional_import("ignite.engine", IgniteInfo.OPT_IMPORT_VERSION, min_version, "Events")

monai/handlers/trt_handler.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,8 @@
1313

1414
from typing import TYPE_CHECKING
1515

16-
from monai.config import IgniteInfo
1716
from monai.networks import trt_compile
18-
from monai.utils import min_version, optional_import
17+
from monai.utils import IgniteInfo, min_version, optional_import
1918

2019
Events, _ = optional_import("ignite.engine", IgniteInfo.OPT_IMPORT_VERSION, min_version, "Events")
2120
if TYPE_CHECKING:

0 commit comments

Comments
 (0)