chore: cleanup audio_recording_merged example (#2093)

* Cleanup example

* move warning

Author: OmLanke

examples/audio_recording_merged.py

@@ -6,7 +6,6 @@
 from discord.sinks import MP3Sink
 
 bot = discord.Bot()
-connections: dict[int, discord.VoiceClient] = {}
 
 
 @bot.event
@@ -55,8 +54,7 @@ async def join(ctx: discord.ApplicationContext):
     if not voice:
         return await ctx.respond("You're not in a vc right now")
 
-    vc = await voice.channel.connect()
-    connections.update({ctx.guild.id: vc})
+    await voice.channel.connect()
 
     await ctx.respond("Joined!")
 
@@ -69,7 +67,7 @@ async def start(ctx: discord.ApplicationContext):
     if not voice:
         return await ctx.respond("You're not in a vc right now")
 
-    vc = connections.get(ctx.guild.id)
+    vc: discord.VoiceClient = ctx.voice_client
 
     if not vc:
         return await ctx.respond(
@@ -80,7 +78,7 @@ async def start(ctx: discord.ApplicationContext):
         MP3Sink(),
         finished_callback,
         ctx.channel,
-        sync_start=True,
+        sync_start=True,  # WARNING: This feature is very unstable and may break at any time.
     )
 
     await ctx.respond("The recording has started!")
@@ -89,7 +87,7 @@ async def start(ctx: discord.ApplicationContext):
 @bot.command()
 async def stop(ctx: discord.ApplicationContext):
     """Stop the recording"""
-    vc = connections.get(ctx.guild.id)
+    vc: discord.VoiceClient = ctx.voice_client
 
     if not vc:
         return await ctx.respond("There's no recording going on right now")
@@ -102,7 +100,7 @@ async def stop(ctx: discord.ApplicationContext):
 @bot.command()
 async def leave(ctx: discord.ApplicationContext):
     """Leave the voice channel!"""
-    vc = connections.get(ctx.guild.id)
+    vc: discord.VoiceClient = ctx.voice_client
 
     if not vc:
         return await ctx.respond("I'm not in a vc right now")