Skip to content

Commit 77c6945

Browse files
committed
Use PROJECT_SOURCE_DIR for submodule compatibility
I used CMAKE_SOURCE_DIR to refer to the top-level source directory in the ShardInstantiation.cmake file, but this can cause issues with git submodules. Instead, we should use PROJECT_SOURCE_DIR to ensure compatibility when this project is used as a submodule in another project.
1 parent fa71c45 commit 77c6945

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

cmake/ShardInstantiation.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ function(generate_sharded_instantiations)
8181
foreach(SHARD_ID RANGE 0 ${LAST_SHARD_ID})
8282
set(NUM_SHARDS "${GEN_SHARDED_NUM_SHARDS}")
8383
set(SHARD_FUNCTION_PATH "${GEN_SHARDED_OUTPUT_DIR}/${INSTANCES}_shard_${SHARD_ID}.cpp")
84-
set(SHARD_FUNCTION_TEMPLATE "${CMAKE_SOURCE_DIR}/cmake/instantiate_shard.in")
84+
set(SHARD_FUNCTION_TEMPLATE "${PROJECT_SOURCE_DIR}/cmake/instantiate_shard.in")
8585
configure_file(
8686
"${SHARD_FUNCTION_TEMPLATE}"
8787
"${SHARD_FUNCTION_PATH}"
@@ -101,7 +101,7 @@ function(generate_sharded_instantiations)
101101

102102
# Generate the caller function.
103103
set(CALLER_FUNCTION_PATH "${GEN_SHARDED_OUTPUT_DIR}/${INSTANCES}.cpp")
104-
set(FUNCTION_TEMPLATE "${CMAKE_SOURCE_DIR}/cmake/call_shard.in")
104+
set(FUNCTION_TEMPLATE "${PROJECT_SOURCE_DIR}/cmake/call_shard.in")
105105
configure_file(
106106
"${FUNCTION_TEMPLATE}"
107107
"${CALLER_FUNCTION_PATH}"

0 commit comments

Comments
 (0)