Skip to content

Commit a2ccb75

Browse files
ezyangiotamudelta
authored andcommitted
Retainable is no more (pytorch#11900)
Summary: Stack:     :black_circle:  **pytorch#11900 Retainable is no more**  [:yellow_heart:](https://our.intern.facebook.com/intern/diff/D9977505/)     :white_circle:  pytorch#11902 Refactor fastGet/fastSet for clarity, removing a null pointer check.  [:yellow_heart:](https://our.intern.facebook.com/intern/diff/D9977654/) Kill it with fire Pull Request resolved: pytorch#11900 Differential Revision: D9979779 Pulled By: ezyang fbshipit-source-id: 0a437e7a0baadb6440e7dc39a01b4a406171faa7
1 parent 0ffb286 commit a2ccb75

File tree

2 files changed

+4
-64
lines changed

2 files changed

+4
-64
lines changed

aten/src/ATen/Retainable.h

Lines changed: 0 additions & 60 deletions
This file was deleted.

torch/csrc/jit/interpreter.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -327,10 +327,10 @@ struct PreprocessGraph {
327327

328328
};
329329

330-
// previously the interpreter worked with at::Retainable values,
331-
// which are annoying to handle since 99% of values are at::Tensor anyway
332-
// instead we create a fake subclass of TensorImpl that can be subclassed
333-
// to hold arbitrary things
330+
// Sometimes we want to pass things that are not tensors. Instead of
331+
// coming up with some "superclass" for tensor, which is annoying since
332+
// 99% of values are at::Tensor, we instead we create a fake subclass of
333+
// TensorImpl that can be subclassed to hold arbitrary things
334334
// Note: this is currently unused but will probably be useful in the future,
335335
// so we keep it around
336336
struct ContainerTensor : public at::TensorImpl {

0 commit comments

Comments
 (0)