Skip to content

Commit 2fb841b

Browse files
committed
remove unnecessary margins
1 parent 0a43008 commit 2fb841b

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

extensions/shared/library/src/main/java/app/revanced/extension/shared/Utils.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -802,7 +802,7 @@ public static Pair<Dialog, LinearLayout> createCustomDialog(
802802
ViewGroup.LayoutParams.MATCH_PARENT,
803803
ViewGroup.LayoutParams.WRAP_CONTENT
804804
);
805-
layoutParams.setMargins(0, 0, 0, dip8);
805+
layoutParams.setMargins(0, 0, 0, dip16);
806806
titleView.setLayoutParams(layoutParams);
807807
mainLayout.addView(titleView);
808808
}
@@ -833,7 +833,6 @@ public static Pair<Dialog, LinearLayout> createCustomDialog(
833833
ViewGroup.LayoutParams.MATCH_PARENT,
834834
ViewGroup.LayoutParams.WRAP_CONTENT
835835
);
836-
messageParams.setMargins(dip8, dip8, dip8, dip16);
837836
messageView.setLayoutParams(messageParams);
838837
contentContainer.addView(messageView);
839838
}
@@ -858,7 +857,6 @@ public static Pair<Dialog, LinearLayout> createCustomDialog(
858857
LinearLayout.LayoutParams.MATCH_PARENT,
859858
LinearLayout.LayoutParams.WRAP_CONTENT
860859
);
861-
editTextParams.setMargins(0, dip8, 0, dip16);
862860
contentContainer.addView(editText, editTextParams);
863861
}
864862

@@ -870,7 +868,7 @@ public static Pair<Dialog, LinearLayout> createCustomDialog(
870868
LinearLayout.LayoutParams.MATCH_PARENT,
871869
LinearLayout.LayoutParams.WRAP_CONTENT
872870
);
873-
buttonContainerParams.setMargins(0, dip8, 0, 0);
871+
buttonContainerParams.setMargins(0, dip16, 0, 0);
874872
buttonContainer.setLayoutParams(buttonContainerParams);
875873

876874
// Lists to track buttons.

extensions/shared/library/src/main/java/app/revanced/extension/shared/settings/preference/CustomDialogListPreference.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,6 @@ protected void showDialog(Bundle state) {
176176
LinearLayout.LayoutParams.MATCH_PARENT,
177177
finalHeight // Use calculated height directly.
178178
);
179-
final int marginHorizontal = dipToPixels(8);
180-
listViewParams.setMargins(0, marginHorizontal, 0, marginHorizontal);
181179
mainLayout.addView(listView, mainLayout.getChildCount() - 1, listViewParams);
182180

183181
// Handle item click to select value and dismiss dialog.

0 commit comments

Comments
 (0)