fix editText rounded background when scrolling

Author: MarcaDian

extensions/shared/library/src/main/java/app/revanced/extension/shared/Utils.java

@@ -810,6 +810,15 @@ public static Pair<Dialog, LinearLayout> createCustomDialog(
         // Create content container (message/EditText) inside a ScrollView.
         ScrollView contentScrollView = new ScrollView(context);
         contentScrollView.setVerticalScrollBarEnabled(false); // Disable the vertical scrollbar.
+        contentScrollView.setOverScrollMode(View.OVER_SCROLL_NEVER);
+        if (editText != null) {
+            ShapeDrawable scrollViewBackground = new ShapeDrawable(new RoundRectShape(
+                    createCornerRadii(10), null, null));
+            scrollViewBackground.getPaint().setColor(getEditTextBackground());
+            contentScrollView.setPadding(dip8, dip8, dip8, dip8);
+            contentScrollView.setBackground(scrollViewBackground);
+            contentScrollView.setClipToOutline(true);
+        }
         LinearLayout contentContainer = new LinearLayout(context);
         contentContainer.setOrientation(LinearLayout.VERTICAL);
         LinearLayout.LayoutParams contentParams = new LinearLayout.LayoutParams(
@@ -847,13 +856,8 @@ public static Pair<Dialog, LinearLayout> createCustomDialog(
             }
             // Style the EditText to match the dialog theme.
             editText.setTextColor(getAppForegroundColor());
-            editText.setBackgroundColor(isDarkModeEnabled() ? Color.BLACK : Color.WHITE);
-            editText.setPadding(dip8, dip8, dip8, dip8);
-            ShapeDrawable editTextBackground = new ShapeDrawable(new RoundRectShape(
-                    createCornerRadii(10), null, null));
-            editTextBackground.getPaint().setColor(getEditTextBackground()); // Background color for EditText.
-            editText.setBackground(editTextBackground);
-
+            editText.setBackgroundColor(Color.TRANSPARENT);
+            editText.setPadding(0, 0, 0, 0);
             LinearLayout.LayoutParams editTextParams = new LinearLayout.LayoutParams(
                     LinearLayout.LayoutParams.MATCH_PARENT,
                     LinearLayout.LayoutParams.WRAP_CONTENT

extensions/shared/library/src/main/java/app/revanced/extension/shared/settings/preference/ColorPickerPreference.java

@@ -298,7 +298,6 @@ protected void showDialog(Bundle state) {
         // Horizontal layout for preview and EditText.
         LinearLayout inputLayout = new LinearLayout(context);
         inputLayout.setOrientation(LinearLayout.HORIZONTAL);
-        inputLayout.setPadding(0, 0, 0, dipToPixels(10));
 
         dialogColorPreview = new TextView(context);
         LinearLayout.LayoutParams previewParams = new LinearLayout.LayoutParams(

extensions/youtube/src/main/java/app/revanced/extension/youtube/sponsorblock/objects/SegmentCategoryListPreference.java

@@ -88,8 +88,6 @@ protected void showDialog(Bundle state) {
             // Create the main layout for the dialog content.
             LinearLayout contentLayout = new LinearLayout(context);
             contentLayout.setOrientation(LinearLayout.VERTICAL);
-            final int dip10 = dipToPixels(10);
-            contentLayout.setPadding(0, 0, 0, dip10);
 
             // Add behavior selection radio buttons.
             RadioGroup radioGroup = new RadioGroup(context);
@@ -103,7 +101,7 @@ protected void showDialog(Bundle state) {
                 radioGroup.addView(radioButton);
             }
             radioGroup.setOnCheckedChangeListener((group, checkedId) -> selectedDialogEntryIndex = checkedId);
-            radioGroup.setPadding(dip10, 0, 0, 0);
+            radioGroup.setPadding(dipToPixels(10), 0, 0, 0);
             contentLayout.addView(radioGroup);
 
             // Inflate the color picker view.
@@ -131,7 +129,7 @@ protected void showDialog(Bundle state) {
             gridParams = new GridLayout.LayoutParams();
             gridParams.rowSpec = GridLayout.spec(0); // First row.
             gridParams.columnSpec = GridLayout.spec(1); // Second column.
-            gridParams.setMargins(0, 0, dip10, 0);
+            gridParams.setMargins(0, 0, dipToPixels(10), 0);
             dialogColorDotView = new TextView(context);
             dialogColorDotView.setLayoutParams(gridParams);
             gridLayout.addView(dialogColorDotView);