Skip to content

observeOn should unsubscribe onError #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benjchristensen opened this issue Sep 11, 2014 · 1 comment
Closed

observeOn should unsubscribe onError #1681

benjchristensen opened this issue Sep 11, 2014 · 1 comment
Milestone
1.0

Comments

@benjchristensen
Copy link
Member

Right now an onError to observeOn does not unsubscribe. This is normal behavior for most operators, but in this case can mean the source keeps spinning if the error did not come from the source (such as MissingBackpressureException) until the error propagates across the thread boundary and triggers an unsubscribe.

Across async boundaries I think the unsubscribe should be eager to stop the source faster.

This is related to #1680
@benjchristensen benjchristensen added this to the 1.0 milestone Sep 11, 2014
@benjchristensen benjchristensen mentioned this issue Sep 11, 2014
Merged
@benjchristensen
Copy link
Member Author

@headinthebox and I discussed ... I will make this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@benjchristensen