Skip to content

Commit 3623868

Browse files
Saadnajmipull[bot]ryanlntnntremganandraj
committed
Don't override key presses "Space"/"Enter" to perform onClick in RCTView (microsoft#941)
* add pull yml * match handleOpenURLNotification event payload with iOS (microsoft#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (microsoft#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (microsoft#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855) * add pull yml * match handleOpenURLNotification event payload with iOS (microsoft#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (microsoft#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * remove performKeyEquivalent Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
1 parent 65f2be8 commit 3623868

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

React/Views/RCTView.m

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1393,19 +1393,6 @@ - (BOOL)acceptsFirstResponder
13931393
return ([self focusable] && [NSApp isFullKeyboardAccessEnabled]) || [super acceptsFirstResponder];
13941394
}
13951395

1396-
- (BOOL)performKeyEquivalent:(NSEvent *)theEvent
1397-
{
1398-
if (self.onClick != nil &&
1399-
[self focusable] &&
1400-
[[self window] firstResponder] == self) {
1401-
if ([[theEvent characters] isEqualToString:@" "] || [[theEvent characters] isEqualToString:@"\r"]) {
1402-
self.onClick(nil);
1403-
return YES;
1404-
}
1405-
}
1406-
return [super performKeyEquivalent:theEvent];
1407-
}
1408-
14091396
- (void)updateTrackingAreas
14101397
{
14111398
if (_trackingArea) {

0 commit comments

Comments
 (0)