Review

Author: EtienneM

mongo/document/base.go

@@ -13,7 +13,7 @@ type Base struct {
 	UpdatedAt time.Time     `bson:"updated_at" json:"updated_at"`
 }
 
-func (d *Base) IsPersisted() bool {
+func (d Base) IsPersisted() bool {
 	return !d.CreatedAt.IsZero()
 }
 
@@ -45,6 +45,6 @@ func (d *Base) destroy(ctx context.Context, collection string) error {
 	return ReallyDestroy(ctx, collection, d)
 }
 
-func (d *Base) Validate(ctx context.Context) *ValidationErrors {
+func (d Base) Validate(ctx context.Context) *ValidationErrors {
 	return nil
 }

mongo/document/document.go

@@ -31,8 +31,8 @@ type scopable interface {
 	scope(bson.M) bson.M
 }
 
-var _ scopable = &Base{}
-var _ scopable = &Paranoid{}
+var _ scopable = Base{}
+var _ scopable = Paranoid{}
 
 type destroyable interface {
 	destroy(ctx context.Context, collectionName string) error
@@ -49,7 +49,7 @@ type Validable interface {
 	Validate(ctx context.Context) *ValidationErrors
 }
 
-var _ Validable = &Base{}
+var _ Validable = Base{}
 
 // Create inser the document in the database, returns an error if document already exists and set CreatedAt timestamp
 func Create(ctx context.Context, collectionName string, doc document) error {
@@ -236,24 +236,22 @@ func Update(ctx context.Context, collectionName string, update bson.M, doc docum
 }
 
 func EnsureParanoidIndices(ctx context.Context, collectionNames ...string) {
-	go func() {
-		log := logger.Get(ctx)
-
-		for _, collectionName := range collectionNames {
-			log := logger.Get(ctx).WithFields(logrus.Fields{
-				"init":       "setup-indices",
-				"collection": collectionName,
-			})
-			ctx := logger.ToCtx(ctx, log)
-			log.Info("Setup the MongoDB index")
-
-			c := mongo.Session(log).Clone().DB("").C(collectionName)
-			defer c.Database.Session.Close()
-			err := c.EnsureIndexKey("deleted_at")
-			if err != nil {
-				log.WithError(err).Error("fail to setup the deleted_at index")
-				return
-			}
+	log := logger.Get(ctx)
+
+	for _, collectionName := range collectionNames {
+		log = logger.Get(ctx).WithFields(logrus.Fields{
+			"init":       "setup-indices",
+			"collection": collectionName,
+		})
+		ctx = logger.ToCtx(ctx, log)
+		log.Info("Setup the MongoDB index")
+
+		c := mongo.Session(log).Clone().DB("").C(collectionName)
+		defer c.Database.Session.Close()
+		err := c.EnsureIndexKey("deleted_at")
+		if err != nil {
+			log.WithError(err).Error("fail to setup the deleted_at index")
+			continue
 		}
-	}()
+	}
 }

mongo/document/paranoid.go

@@ -20,7 +20,7 @@ func (d *Paranoid) setDeletedAt(t time.Time) {
 	d.DeletedAt = &t
 }
 
-func (d *Paranoid) scope(query bson.M) bson.M {
+func (d Paranoid) scope(query bson.M) bson.M {
 	if _, ok := query["deleted_at"]; !ok {
 		query["deleted_at"] = nil
 	}