Skip to content

Commit 55c1b05

Browse files
committed
refactor: reverte Table Renderer.js and remove props colLimit rowLimit
1 parent 604c209 commit 55c1b05

File tree

3 files changed

+5
-34
lines changed

3 files changed

+5
-34
lines changed

src/Pivottable.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,7 @@ export default {
66
defaultProps
77
],
88
computed: {
9-
tableRenderer () {
10-
const makeRenderer = TableRenderer.makeRenderer
11-
return {
12-
Table: makeRenderer({ name: 'vue-table' }),
13-
'Table Heatmap': makeRenderer({ heatmapMode: 'full', name: 'vue-table-heatmap' }),
14-
'Table Col Heatmap': makeRenderer({ heatmapMode: 'col', name: 'vue-table-col-heatmap' }),
15-
'Table Row Heatmap': makeRenderer({ heatmapMode: 'row', name: 'vue-table-col-heatmap' }),
16-
'Export Table TSV': TableRenderer.TSVExportRenderer
17-
}
18-
},
199
rendererItems () {
20-
const TableRenderer = this.tableRenderer
2110
return this.renderers || Object.assign({}, TableRenderer)
2211
}
2312
},

src/PivottableUi.js

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,6 @@ export default {
5050
return []
5151
}
5252
},
53-
rowLimit: {
54-
type: Number,
55-
default: 0
56-
},
57-
colLimit: {
58-
type: Number,
59-
default: 0
60-
},
6153
menuLimit: {
6254
type: Number,
6355
default: 500
@@ -73,18 +65,7 @@ export default {
7365
appliedFilter () {
7466
return this.propsData.valueFilter
7567
},
76-
tableRenderer () {
77-
const makeRenderer = TableRenderer.makeRenderer
78-
return {
79-
Table: makeRenderer({ name: 'vue-table' }),
80-
'Table Heatmap': makeRenderer({ heatmapMode: 'full', name: 'vue-table-heatmap' }),
81-
'Table Col Heatmap': makeRenderer({ heatmapMode: 'col', name: 'vue-table-col-heatmap' }),
82-
'Table Row Heatmap': makeRenderer({ heatmapMode: 'row', name: 'vue-table-col-heatmap' }),
83-
'Export Table TSV': TableRenderer.TSVExportRenderer
84-
}
85-
},
8668
rendererItems () {
87-
const TableRenderer = this.tableRenderer
8869
return (this.renderers) || Object.assign({}, TableRenderer, PlotlyRenderer)
8970
},
9071
aggregatorItems () {
@@ -215,8 +196,6 @@ export default {
215196
sortonlyFromDragDrop: this.sortonlyFromDragDrop,
216197
disabledFromDragDrop: this.disabledFromDragDrop,
217198
menuLimit: this.menuLimit,
218-
rowLimit: this.rowLimit,
219-
colLimit: this.colLimit,
220199
attributes: value.attributes,
221200
unusedAttrs: this.unusedAttrs,
222201
sorters: this.sorters,

src/TableRenderer.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -371,6 +371,9 @@ const TSVExportRenderer = {
371371
}
372372

373373
export default {
374-
makeRenderer,
375-
TSVExportRenderer
374+
Table: makeRenderer({ name: 'vue-table' }),
375+
'Table Heatmap': makeRenderer({ heatmapMode: 'full', name: 'vue-table-heatmap' }),
376+
'Table Col Heatmap': makeRenderer({ heatmapMode: 'col', name: 'vue-table-col-heatmap' }),
377+
'Table Row Heatmap': makeRenderer({ heatmapMode: 'row', name: 'vue-table-col-heatmap' }),
378+
'Export Table TSV': TSVExportRenderer
376379
}

0 commit comments

Comments
 (0)