Merge pull request #7268 from StoDevX/drew/remove-feature-flag-implementation

remove app-config and feature flag implementation

Author: drewvolz

modules/app-config/__tests__/useCourseSearchRecentsScreen.test.tsx

@@ -6,29 +6,13 @@ import {
 	setItem,
 	setStoragePrefix,
 } from '@frogpond/storage'
-import {AppConfigEntry} from '@frogpond/app-config'
 import type {FilterComboType} from '../views/sis/course-search/lib/format-filter-combo'
 import type {CourseType, TermType} from './course-search/types'
 
 export {clearAsyncStorage}
 
 setStoragePrefix('aao:')
 
-/// MARK: Feature flags
-
-const featureFlagsKey = 'app:feature-flag'
-export function setFeatureFlag(
-	name: AppConfigEntry,
-	value: boolean,
-): Promise<void> {
-	const key = `${featureFlagsKey}:${name}`
-	return setItem(key, value)
-}
-export function getFeatureFlag(name: AppConfigEntry): Promise<boolean> {
-	const key = `${featureFlagsKey}:${name}`
-	return getItemAsBoolean(key)
-}
-
 /// MARK: Settings
 
 const homescreenOrderKey = 'homescreen:view-order'

modules/app-config/index.ts

@@ -284,11 +284,6 @@ const SettingsStackScreens = () => {
 
 			{/* developer */}
 			<SettingsStack.Group>
-				<SettingsStack.Screen
-					component={settings.FeatureFlagView}
-					name="FeatureFlags"
-					options={settings.FeatureFlagNavigationOptions}
-				/>
 				<SettingsStack.Screen
 					component={settings.APITestView}
 					name="APITest"

modules/app-config/package.json

@@ -49,7 +49,7 @@ export type RootViewsParamList = {
 	More: undefined
 	PrintJobs: undefined
 	StudentOrgs: undefined
-} & Pick<MiscViewParamList, 'CourseSearchResults'>
+}
 
 export type CafeMenuParamList = {
 	CarletonBurtonMenu: undefined
@@ -100,7 +100,6 @@ export type SettingsStackParamList = {
 	Credits: undefined
 	[debug.NavigationKey]: {keyPath: string[]}
 	Faq: undefined
-	FeatureFlags: undefined
 	IconSettings: undefined
 	Legal: undefined
 	NetworkLogger: undefined

modules/app-config/types.ts

@@ -25,7 +25,7 @@ const styles = StyleSheet.create({
 
 function HomePage(): JSX.Element {
 	let navigation = useNavigation()
-	let allViews = AllViews().filter((view) => !view.disabled ?? true)
+	let allViews = AllViews().filter((view) => !view.disabled)
 	let columns = partitionByIndex(allViews)
 
 	return (

package-lock.json

@@ -7,10 +7,6 @@ export {IconSettingsView} from './screens/change-icon'
 export {CreditsView} from './screens/credits'
 export {LegalView} from './screens/legal'
 export {PrivacyView} from './screens/privacy'
-export {
-	View as FeatureFlagView,
-	NavigationOptions as FeatureFlagNavigationOptions,
-} from './screens/feature-flags'
 
 // Developer settings
 export {DebugRootView} from './screens/debug'

source/lib/storage.ts

@@ -14,7 +14,6 @@ export const DeveloperSection = (): React.ReactElement => {
 	const onComponentsButton = () => navigation.navigate('ComponentLibrary')
 	const onAPIButton = () => navigation.navigate('APITest')
 	const onBonAppButton = () => navigation.navigate('BonAppPicker')
-	const onFeatureFlagsButton = () => navigation.navigate('FeatureFlags')
 	const onDebugButton = () => navigation.navigate(DebugKey, {keyPath: ['Root']})
 	const onNetworkLoggerButton = () => navigation.navigate('NetworkLogger')
 	const sendSentryMessage = () => {
@@ -42,7 +41,6 @@ export const DeveloperSection = (): React.ReactElement => {
 	return (
 		<>
 			<Section header="DEVELOPER">
-				<PushButtonCell onPress={onFeatureFlagsButton} title="Feature Flags" />
 				<PushButtonCell onPress={onComponentsButton} title="Components" />
 				<PushButtonCell onPress={onAPIButton} title="API Tester" />
 				<PushButtonCell onPress={onBonAppButton} title="Bon Appetit Picker" />