-
Notifications
You must be signed in to change notification settings - Fork 81
Clean up broken unit tests #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Why disable tests instead of fixing failing syntax test assertions? |
Also a possibility. Some of them don't really make sense though. IIRC there are some number suffix things that no one would use. |
@michaelblyons in my local fork I have marked the ambiguous float long syntax as |
Sure! DeathAxe is usually not excited about deprecation marking, but this case was always ambiguous. And now that there's official guidance, I think it makes sense. |
@michaelblyons Thank you! I'd like to resolve #186 before sending in this new PR. One thing I don't understand, though, is the error
Which pops up for every variable present in the test while testing it on my local Sublime Text. I tried googling it, but I couldn't find any relevant results. Why is the |
If you test for any symbols matching, it tests for all symbols unless you have |
I see. So to solve these kinds of errors there should be a test for each variable name? |
Your options are
|
I understand now, thank you! |
Disable non-working tests so PRs are easy to judge.
The text was updated successfully, but these errors were encountered: