Skip to content

Commit 9e0964a

Browse files
authored
updating contribution guide to include requirement for unit tests to be passing and code is linted with phpcs (#170)
1 parent 45f57ea commit 9e0964a

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,12 @@ We want your work to be readable by others; therefore, we encourage you to note
6262

6363
If you used a Wikipedia article or some other source material to create your algorithm, please add the URL in a docstring or comment to help your reader
6464

65-
- Write tests
65+
- Write proper unit tests (see examples in [tests](https://github.com/TheAlgorithms/PHP/tree/master/tests) and ensure all unit tests are passing (composer run-script test)
66+
6667
- Avoid importing external libraries for basic algorithms. Only use them for complicated algorithms
6768

69+
- Ensure code is linted with phpcs, and passing all linting checks (vendor/bin/phpcs -n)
70+
6871
#### Other Standard While Submitting Your Work
6972

7073
- File extension for code should be `.php`

0 commit comments

Comments
 (0)