Skip to content

Consider generalizing Url.createObjectURL to blob_like #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Oct 28, 2021 · 1 comment
Closed

Consider generalizing Url.createObjectURL to blob_like #33

ghost opened this issue Oct 28, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented Oct 28, 2021

I'm using

  external asFile: Webapi.Blob.t => Webapi.File.t = "%identity"

to work around the createObjectURL requiring a File.t. Consider generalizing createObjectURL in the future. Thanks.

@TheSpyder
Copy link
Owner

TheSpyder commented Oct 29, 2021

For the moment that's just what we imported from bs-webapi. Our aim is to retain compatibility where possible for 1.0 because a lot of people will suddenly need to migrate when ReScript 10 is released.

Thank you for the idea. I'm tracking ways to improve the Fetch API in #30 - I'll add a note there. This isn't specifically fetch related, but it's fairly close and I think the opportunity for a breaking change is a good time to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant