Handle symbols in implementationOf

Resolves #2234

Author: Gerrit0

CHANGELOG.md

@@ -21,6 +21,7 @@
 -   Fixed semantic coloring in type and function signatures, #2227.
 -   Fixed issue where removing a reflection indirectly containing an object/function type would only partially remove the reflection, #2231.
 -   Fixed "Implementation of X.y" links if a mixture of methods and property-methods are used, #2233.
+-   "Implementation of" text to symbol-properties not contained in the documentation will now use the resolved name instead of a `__@` symbol name, #2234.
 -   Fix expansion of globs if a single entry point is provided, #2235.
 -   Fixed broken theme toggle if the page contained a member named "theme".
 

src/lib/converter/plugins/ImplementsPlugin.ts

@@ -13,6 +13,7 @@ import { filterMap, zip } from "../../utils/array";
 import { Component, ConverterComponent } from "../components";
 import type { Context } from "../context";
 import { Converter } from "../converter";
+import { getHumanName } from "../../utils";
 
 /**
  * A plugin that detects interface implementations of functions and
@@ -405,7 +406,7 @@ function createLink(
     isOverwrite: boolean
 ) {
     const project = context.project;
-    const name = `${expr.expression.getText()}.${symbol.name}`;
+    const name = `${expr.expression.getText()}.${getHumanName(symbol.name)}`;
 
     link(reflection);
     link(reflection.getSignature);

src/test/converter2/issues/gh2234.ts

@@ -0,0 +1,11 @@
+export interface ReadonlyCharMap extends Iterable<string> {
+    at(x: number): string;
+}
+
+export class CharMap implements ReadonlyCharMap {
+    at() {
+        return "";
+    }
+
+    *[Symbol.iterator](): Iterator<string> {}
+}

src/test/issues.c2.test.ts

@@ -1079,4 +1079,18 @@ describe("Issue Tests", () => {
             );
         }
     });
+
+    it("Handles implementationOf with symbols #2234", () => {
+        const project = convert();
+        const cm = query(project, "CharMap");
+        equal(
+            cm.children?.map((c) => c.name),
+            ["constructor", "[iterator]", "at"]
+        );
+
+        equal(
+            cm.children[1].implementationOf?.name,
+            "ReadonlyCharMap.[iterator]"
+        );
+    });
 });