Skip to content

Commit df38161

Browse files
authored
Upgrade Vue.js CLI to 4.x (#969)
* Package updates * Update for new output names * Update permissions editor to vue-cli 4.3.x * Update vue-cdr-access packages * Router push needs a catch block, as navigating to same route throws an error, see vuejs/vue-router#2881 (comment). It seems it's not supposed to throw the error if parameters are changed, so maybe a bug in vue-router? * * Update vue-cdr-access packages * Security fixes * Fix issue with js build not overwriting previous build * Update vue-test-utils and fix tests. There were breaking changes in 1.0.0-beta.30
1 parent 6a95d6a commit df38161

27 files changed

+19322
-11645
lines changed

Makefile

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,13 @@ endif
1414

1515
cat /dev/null > static/js/vue-permissions.js
1616

17-
ifeq ($(DEPLOY_TYPE), prod)
18-
cat static/js/admin/vue-permissions-editor/dist/js/chunk-vendors*.js > static/js/vue-permissions.js
19-
endif
17+
cat static/js/admin/vue-permissions-editor/dist/js/chunk-vendors*js > static/js/vue-permissions.js
18+
2019

2120
# Add new line so app*.js doesn't get commented out
2221
echo >> static/js/vue-permissions.js
2322

24-
ifeq ($(DEPLOY_TYPE), prod)
25-
cat static/js/admin/vue-permissions-editor/dist/js/app*.js >> static/js/vue-permissions.js
26-
else
27-
cat static/js/admin/vue-permissions-editor/dist/app.js >> static/js/vue-permissions.js
28-
endif
23+
cat static/js/admin/vue-permissions-editor/dist/js/app*js >> static/js/vue-permissions.js
2924

3025
cat static/js/lib/jquery.min.js > static/js/cdr-admin.js
3126
echo "define('jquery-ui', ['jquery'], function ($$) {" >> static/js/cdr-admin.js
@@ -56,7 +51,7 @@ endif
5651
> static/css/cdr_admin.css
5752

5853
ifeq ($(DEPLOY_TYPE), prod)
59-
cat static/js/admin/vue-permissions-editor/dist/css/app*.css >> static/css/cdr_admin.css
54+
cat static/js/admin/vue-permissions-editor/dist/css/app*css >> static/css/cdr_admin.css
6055
endif
6156

6257
ifneq ($(VERSION), "")
@@ -67,7 +62,7 @@ ifneq ($(VERSION), "")
6762
endif
6863

6964
build-access:
70-
# Build vue application(s) files
65+
# Build vue application(s) files
7166
npm --prefix static/js/vue-cdr-access install
7267

7368
ifeq ($(DEPLOY_TYPE), prod)
@@ -76,7 +71,8 @@ else
7671
npm --prefix static/js/vue-cdr-access run build-dev
7772
endif
7873

79-
# Make sure file is empty
74+
# Make sure files are empty
75+
cat /dev/null > static/js/vue-access.js
8076
cat /dev/null > static/css/sass/cdr-ui.scss
8177

8278
cat static/css/sass/cdr_homepage.scss \
@@ -88,24 +84,14 @@ endif
8884
cat static/js/lib/jquery-ui-access.min.js >> static/js/cdr-access.js
8985
echo "});" >> static/js/cdr-access.js
9086

91-
cat /dev/null > static/js/vue-access.js
92-
93-
ifeq ($(DEPLOY_TYPE), prod)
94-
cat static/js/vue-cdr-access/dist/js/chunk-vendors*.js >> static/js/vue-access.js
95-
endif
87+
cat static/js/vue-cdr-access/dist/js/chunk-vendors*js >> static/js/vue-access.js
9688

9789
# Add new line so app*.js doesn't get commented out
9890
echo >> static/js/vue-access.js
99-
100-
ifeq ($(DEPLOY_TYPE), prod)
101-
cat static/js/vue-cdr-access/dist/js/app*.js >> static/js/vue-access.js
102-
else
103-
cat static/js/vue-cdr-access/dist/app.js >> static/js/vue-access.js
104-
endif
91+
cat static/js/vue-cdr-access/dist/js/app*js >> static/js/vue-access.js
10592

10693
cat \
10794
static/js/public/src/*.js \
108-
static/js/vue-access.js \
10995
>> static/js/cdr-access.js
11096

11197
cat static/css/reset.css \
@@ -118,7 +104,7 @@ endif
118104
> static/css/cdr_access.css
119105

120106
ifeq ($(DEPLOY_TYPE), prod)
121-
cat static/js/vue-cdr-access/dist/css/app*.css >> static/css/cdr_access.css
107+
cat static/js/vue-cdr-access/dist/css/app*css >> static/css/cdr_access.css
122108
endif
123109
SUSPEND = "n"
124110

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
module.exports = {
22
presets: [
3-
'@vue/app'
3+
'@vue/cli-plugin-babel/preset'
44
]
55
}
Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,3 @@
11
module.exports = {
2-
moduleFileExtensions: [
3-
'js',
4-
'jsx',
5-
'json',
6-
'vue'
7-
],
8-
transform: {
9-
'^.+\\.vue$': 'vue-jest',
10-
'.+\\.(css|styl|less|sass|scss|svg|png|jpg|ttf|woff|woff2)$': 'jest-transform-stub',
11-
'^.+\\.jsx?$': 'babel-jest'
12-
},
13-
transformIgnorePatterns: [
14-
'/node_modules/'
15-
],
16-
moduleNameMapper: {
17-
'^@/(.*)$': '<rootDir>/src/$1'
18-
},
19-
snapshotSerializers: [
20-
'jest-serializer-vue'
21-
],
22-
testMatch: [
23-
'**/tests/unit/**/*.spec.(js|jsx|ts|tsx)|**/__tests__/*.(js|jsx|ts|tsx)'
24-
],
25-
testURL: 'http://localhost/',
26-
watchPlugins: [
27-
'jest-watch-typeahead/filename',
28-
'jest-watch-typeahead/testname'
29-
]
2+
preset: '@vue/cli-plugin-unit-jest'
303
}

0 commit comments

Comments
 (0)