Skip to content

Commit be4d032

Browse files
alex-quiteriojulik
authored andcommitted
MP3: Remove uneeded guard when ID3Tag tries to find an unknown genre (#125)
The guard `rescue nil` can now be safely removed since the original issue is fixed by krists/id3tag#19 related with: #118
1 parent 3e7a574 commit be4d032

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

format_parser.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Gem::Specification.new do |spec|
3232

3333
spec.add_dependency 'ks', '~> 0.0.1'
3434
spec.add_dependency 'exifr', '~> 1.0'
35-
spec.add_dependency 'id3tag', '~> 0.10'
35+
spec.add_dependency 'id3tag', '~> 0.10', '>= 0.10.1'
3636
spec.add_dependency 'faraday', '~> 0.13'
3737
spec.add_dependency 'measurometer', '~> 1'
3838

lib/parsers/mp3_parser.rb

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,7 @@ def self.new(wrapped)
4343
def to_h
4444
tag = __getobj__
4545
MEMBERS.each_with_object({}) do |k, h|
46-
# ID3Tag sometimes raises when trying to find an unknown genre.
47-
# If this guard is removed, it fails when trying to do a gsub on a nil,
48-
# in /lib/id3tag/frames/v2/genre_frame/genre_parser_pre_24.rb:25:in `just_genres'
49-
value = tag.public_send(k) rescue nil
46+
value = tag.public_send(k)
5047
h[k] = value if value
5148
end
5249
end

0 commit comments

Comments
 (0)