Skip to content

When details is not set, results are outputted twice #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YamatoSecurity opened this issue Mar 5, 2025 · 3 comments · Fixed by #1624
Closed

When details is not set, results are outputted twice #1623

YamatoSecurity opened this issue Mar 5, 2025 · 3 comments · Fixed by #1624
Assignees
Labels
bug Something isn't working
Milestone

Comments

@YamatoSecurity
Copy link
Collaborator

When details is not set, results are outputted twice in Details and ExtraFieldInfo. We should just output once in the Details column. I am not sure if this happens in JSON output as well.

@fukusuket Sorry for another bug fix, could you look at this when you have time?

@fukusuket
Copy link
Collaborator

Yes, I will look into it!💪

@fukusuket fukusuket self-assigned this Mar 5, 2025
@fukusuket fukusuket added the bug Something isn't working label Mar 5, 2025
@fukusuket fukusuket added this to the 3.1.1 milestone Mar 5, 2025
@fukusuket
Copy link
Collaborator

This issue did not occur with json-timeline. Therefore, it is a csv-timeline only issue.

% ./hayabusa json-timeline -d ../hayabusa-sample-evtx -r Sec_4741_Info_CmpAcctCreated.yml -w  -q
...
{
    "Timestamp": "2021-12-14 23:42:48.817 +09:00",
    "RuleTitle": "Computer Account Created",
    "Level": "info",
    "Computer": "rootdc1.offsec.lan",
    "Channel": "Sec",
    "EventID": 4741,
    "RecordID": 237294524,
    "Details": {},
    "ExtraFieldInfo": {
        "AccountExpires": "<never>",
        "AllowedToDelegateTo": "-",
        "DisplayName": "<value not set>",
        "DnsHostName": "-",
        "HomeDirectory": "<value not set>",
        "HomePath": "<value not set>",
        "LogonHours": "<value not set>",
        "NewUacValue": "0x84",
        "OldUacValue": "0x0",
        "PasswordLastSet": "<never>",
        "PrimaryGroupId": 515,
        "PrivilegeList": "SeMachineAccountPrivilege",
        "ProfilePath": "<value not set>",
        "SamAccountName": "compnay-88$",
        "ScriptPath": "<value not set>",
        "ServicePrincipalNames": "-",
        "SidHistory": "-",
        "SubjectDomainName": "OFFSEC",
        "SubjectLogonId": "0x308fb82ad",
        "SubjectUserName": "hack1",
        "SubjectUserSid": "S-1-5-21-4230534742-2542757381-3142984815-1234",
        "TargetDomainName": "OFFSEC",
        "TargetSid": "S-1-5-21-4230534742-2542757381-3142984815-1296",
        "TargetUserName": "compnay-88$",
        "UserAccountControl": "PasswordNotRequired-Enabled\\r\\n\\t\\tWorkstationTrustAccount-Enabled",
        "UserParameters": "<value changed, but not displayed>",
        "UserPrincipalName": "-",
        "UserWorkstations": "<value not set>"
    },
    "RuleID": "42a0a842-2b82-4b2d-8e44-5580fb6c38db"
}

@fukusuket
Copy link
Collaborator

@YamatoSecurity
I have one question!
what is the expected output as a csv-timeline when Details is undefined? As with json-timeline, is the expectation that the Details column will be empty?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants