Skip to content

Commit 70c9389

Browse files
committed
Fix unit tests
1 parent 1db1d57 commit 70c9389

File tree

5 files changed

+21
-14
lines changed

5 files changed

+21
-14
lines changed

__tests__/cache-restore.test.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,13 @@ describe('cache-restore', () => {
4545
}
4646
}
4747

48-
let inputs = {} as any;
4948
let saveStateSpy: jest.SpyInstance;
5049
let infoSpy: jest.SpyInstance;
5150
let debugSpy: jest.SpyInstance;
5251
let setOutputSpy: jest.SpyInstance;
5352
let getCommandOutputSpy: jest.SpyInstance;
5453
let restoreCacheSpy: jest.SpyInstance;
5554
let hashFilesSpy: jest.SpyInstance;
56-
let inSpy: jest.SpyInstance;
5755

5856
beforeEach(() => {
5957
// core
@@ -69,10 +67,6 @@ describe('cache-restore', () => {
6967
saveStateSpy = jest.spyOn(core, 'saveState');
7068
saveStateSpy.mockImplementation(() => undefined);
7169

72-
inputs = {};
73-
inSpy = jest.spyOn(core, 'getInput');
74-
inSpy.mockImplementation(name => inputs[name]);
75-
7670
// glob
7771
hashFilesSpy = jest.spyOn(glob, 'hashFiles');
7872
hashFilesSpy.mockImplementation((pattern: string) => {
@@ -137,12 +131,11 @@ describe('cache-restore', () => {
137131
return findCacheFolder(command);
138132
}
139133
});
140-
inputs['node-version'] = 'vABC';
141134

142135
await restoreCache(packageManager, '');
143136
expect(hashFilesSpy).toHaveBeenCalled();
144137
expect(infoSpy).toHaveBeenCalledWith(
145-
`Cache restored from key: node-cache-${platform}-${packageManager}-v2-vABC-${fileHash}`
138+
`Cache restored from key: node-cache-${platform}-${packageManager}-${fileHash}`
146139
);
147140
expect(infoSpy).not.toHaveBeenCalledWith(
148141
`${packageManager} cache is not found`

__tests__/cache-utils.test.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import {
66
PackageManagerInfo,
77
isCacheFeatureAvailable,
88
supportedPackageManagers,
9-
getCommandOutput
9+
getCommandOutput,
10+
resetProjectDirectoriesMemoized
1011
} from '../src/cache-utils';
1112
import fs from 'fs';
1213
import * as cacheUtils from '../src/cache-utils';
@@ -104,9 +105,7 @@ describe('cache-utils', () => {
104105
MockGlobber.create(['/foo', '/bar'])
105106
);
106107

107-
Object.keys(expandedPatternsMemoized).forEach(
108-
key => delete expandedPatternsMemoized[key]
109-
);
108+
resetProjectDirectoriesMemoized();
110109
});
111110

112111
afterEach(() => {

dist/cache-save/index.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60434,7 +60434,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
6043460434
return (mod && mod.__esModule) ? mod : { "default": mod };
6043560435
};
6043660436
Object.defineProperty(exports, "__esModule", ({ value: true }));
60437-
exports.isCacheFeatureAvailable = exports.isGhes = exports.repoHasYarn3ManagedCache = exports.getCacheDirectories = exports.getPackageManagerInfo = exports.getCommandOutputNotEmpty = exports.getCommandOutput = exports.supportedPackageManagers = void 0;
60437+
exports.isCacheFeatureAvailable = exports.isGhes = exports.repoHasYarn3ManagedCache = exports.getCacheDirectories = exports.resetProjectDirectoriesMemoized = exports.getPackageManagerInfo = exports.getCommandOutputNotEmpty = exports.getCommandOutput = exports.supportedPackageManagers = void 0;
6043860438
const core = __importStar(__nccwpck_require__(2186));
6043960439
const exec = __importStar(__nccwpck_require__(1514));
6044060440
const cache = __importStar(__nccwpck_require__(7799));
@@ -60511,6 +60511,11 @@ exports.getPackageManagerInfo = getPackageManagerInfo;
6051160511
* it contains expensive IO operation and thus should be memoized
6051260512
*/
6051360513
let projectDirectoriesMemoized = null;
60514+
/**
60515+
* unit test must reset memoized variables
60516+
*/
60517+
const resetProjectDirectoriesMemoized = () => (projectDirectoriesMemoized = null);
60518+
exports.resetProjectDirectoriesMemoized = resetProjectDirectoriesMemoized;
6051460519
/**
6051560520
* Expands (converts) the string input `cache-dependency-path` to list of directories that
6051660521
* may be project roots

dist/setup/index.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71220,7 +71220,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
7122071220
return (mod && mod.__esModule) ? mod : { "default": mod };
7122171221
};
7122271222
Object.defineProperty(exports, "__esModule", ({ value: true }));
71223-
exports.isCacheFeatureAvailable = exports.isGhes = exports.repoHasYarn3ManagedCache = exports.getCacheDirectories = exports.getPackageManagerInfo = exports.getCommandOutputNotEmpty = exports.getCommandOutput = exports.supportedPackageManagers = void 0;
71223+
exports.isCacheFeatureAvailable = exports.isGhes = exports.repoHasYarn3ManagedCache = exports.getCacheDirectories = exports.resetProjectDirectoriesMemoized = exports.getPackageManagerInfo = exports.getCommandOutputNotEmpty = exports.getCommandOutput = exports.supportedPackageManagers = void 0;
7122471224
const core = __importStar(__nccwpck_require__(2186));
7122571225
const exec = __importStar(__nccwpck_require__(1514));
7122671226
const cache = __importStar(__nccwpck_require__(7799));
@@ -71297,6 +71297,11 @@ exports.getPackageManagerInfo = getPackageManagerInfo;
7129771297
* it contains expensive IO operation and thus should be memoized
7129871298
*/
7129971299
let projectDirectoriesMemoized = null;
71300+
/**
71301+
* unit test must reset memoized variables
71302+
*/
71303+
const resetProjectDirectoriesMemoized = () => (projectDirectoriesMemoized = null);
71304+
exports.resetProjectDirectoriesMemoized = resetProjectDirectoriesMemoized;
7130071305
/**
7130171306
* Expands (converts) the string input `cache-dependency-path` to list of directories that
7130271307
* may be project roots

src/cache-utils.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,11 @@ export const getPackageManagerInfo = async (packageManager: string) => {
119119
*/
120120

121121
let projectDirectoriesMemoized: string[] | null = null;
122+
/**
123+
* unit test must reset memoized variables
124+
*/
125+
export const resetProjectDirectoriesMemoized = () =>
126+
(projectDirectoriesMemoized = null);
122127
/**
123128
* Expands (converts) the string input `cache-dependency-path` to list of directories that
124129
* may be project roots

0 commit comments

Comments
 (0)