Is there any danger to keep ViewModels inside Classes vs inside Composables ?

[radomartinec]

Our project is:

• relatively large KM app for Andorid and iOS
• using voyager for navigation
• Compose UI is shared, consists of ViewModels and screen classes
• there are many screens, many of them share features and components
• we need to use several databases (one at a time) with possibility to switch between them.

Current approach is:

class MyScreen : GenericScreen() {

  @Composable
  override fun ScreenContent() {

    val viewModel = rememberScreenModel { MyViewModel() }

and new approach - would help us with reusability, maintanance etc - would be:

class MyScreen : GenericScreen() {

  val myViewModel: MyViewModel = MyViewModel(inhabitantTypeCode)
  override fun baseViewModel(): BaseViewModel = myViewModel

  @Composable
  override fun ScreenContent() {
    ...
  }

This would allow having a lot of common logic in the GenericScreen, but the model instances would be no longer created by the composable content functions, but by the classes. Instances of the classes are probably kept longer, for navigation reasons, and so the models and all the resources they initialize and use could probably cause leaks and eat resources (db connections etc).

Is this concern valid? How does the voyager handle class instances internally?

Thanks for any insight or comments to this .