Skip to content

Commit c056f99

Browse files
kolyshkinavagin
authored andcommitted
ci/gha/lint: install a recent shellcheck
Instead of using shellcheck v0.7.2 from fedora repo, let's install the latest version (v0.8.0). This allows to remove some "shellcheck disable=..." annotations, and (I hope) better checking quality overall. While at it, remove findutils from dnf install as this package is already installed. Signed-off-by: Kir Kolyshkin <[email protected]>
1 parent 2666eec commit c056f99

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

.github/workflows/lint.yml

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,18 @@ jobs:
99
image: registry.fedoraproject.org/fedora:latest
1010
steps:
1111
- name: Install tools
12-
run: sudo dnf -y install git make python3-flake8 ShellCheck clang-tools-extra which findutils codespell git-clang-format
12+
run: sudo dnf -y install git make python3-flake8 xz clang-tools-extra which codespell git-clang-format
13+
14+
# TODO: remove this and use ShellCheck from repo once F37 with ShellCheck 0.8.0 is out.
15+
- name: install shellcheck
16+
env:
17+
VERSION: v0.8.0
18+
BASEURL: https://github.com/koalaman/shellcheck/releases/download
19+
SHA256: f4bce23c11c3919c1b20bcb0f206f6b44c44e26f2bc95f8aa708716095fa0651
20+
run: |
21+
curl -sSfL --retry 5 $BASEURL/$VERSION/shellcheck-$VERSION.linux.x86_64.tar.xz |
22+
tar xfJ - -C /usr/local/bin --strip 1 shellcheck-$VERSION/shellcheck
23+
sha256sum --strict --check - <<<"$SHA256 /usr/local/bin/shellcheck"
1324
1425
- uses: actions/checkout@v2
1526

0 commit comments

Comments
 (0)