Skip to content

Commit b7c2045

Browse files
nabijaczleweliandrewc12
authored andcommitted
tests: echo-with-arguments review
Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13259
1 parent 0b071e2 commit b7c2045

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

tests/zfs-tests/tests/functional/rsend/rsend_012_pos.ksh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,5 +162,5 @@ while ((i < ${#pair[@]})); do
162162
((i += 2))
163163
done
164164

165-
log_pass "Verify zfs send -R will backup all the filesystem properties " \
165+
log_pass "Verify zfs send -R will backup all the filesystem properties" \
166166
"correctly."

tests/zfs-tests/tests/functional/trim/trim.kshlib

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
#
2323
function get_size_mb
2424
{
25-
du --block-size 1048576 -s "$1" | awk '{printf("%s", $1)}'
25+
du --block-size 1048576 -s "$1" | cut -f1
2626
}
2727

2828
#
@@ -38,14 +38,12 @@ function get_trim_io
3838
# Sum the ind or agg columns of the trim request size histogram.
3939
case "$type" in
4040
"ind")
41-
rval=$(zpool iostat -pr $pool $vdev | awk \
42-
'$1 ~ /[0-9].*/ { sum += $12 } END { print sum }')
43-
echo -n "$rval"
41+
zpool iostat -pr $pool $vdev |
42+
awk '$1 ~ /[0-9].*/ { sum += $12 } END { print sum }'
4443
;;
4544
"agg")
46-
rval=$(zpool iostat -pr $pool $vdev | awk \
47-
'$1 ~ /[0-9].*/ { sum += $13 } END { print sum }')
48-
echo -n "$rval"
45+
zpool iostat -pr $pool $vdev |
46+
awk '$1 ~ /[0-9].*/ { sum += $13 } END { print sum }'
4947
;;
5048
*)
5149
log_fail "Type must be 'ind' or 'agg'"

0 commit comments

Comments
 (0)