Skip to content

Commit 1d2b952

Browse files
Damien Lespiaudanvet
authored andcommitted
drm/i915/skl: Restore the DDI translation tables when enabling PW1
I was dumping the DDI translation tables to make sure my patch updating the HDMI entry was doing the right thing when I noticed that the table was showing reset values after DPMS. And indeed, the DDI translation registers are in power well 1 on SKL, and so we're losing their values when shutting down eDP. Calling intel_prepare_ddi() on PW1 enabling re-programs the table. Reviewed-by: Paulo Zanoni <[email protected]> Signed-off-by: Damien Lespiau <[email protected]> Signed-off-by: Daniel Vetter <[email protected]>
1 parent 2540039 commit 1d2b952

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/gpu/drm/i915/intel_runtime_pm.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,10 @@ static void skl_power_well_post_enable(struct drm_i915_private *dev_priv,
223223
1 << PIPE_C | 1 << PIPE_B);
224224
}
225225

226-
if (power_well->data == SKL_DISP_PW_1)
226+
if (power_well->data == SKL_DISP_PW_1) {
227+
intel_prepare_ddi(dev);
227228
gen8_irq_power_well_post_enable(dev_priv, 1 << PIPE_A);
229+
}
228230
}
229231

230232
static void hsw_set_power_well(struct drm_i915_private *dev_priv,

0 commit comments

Comments
 (0)