Skip to content

Commit bab5e2c

Browse files
committed
fix ut
1 parent e991905 commit bab5e2c

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@
163163
import org.apache.doris.nereids.trees.plans.logical.LogicalOlapScan;
164164
import org.apache.doris.nereids.trees.plans.logical.LogicalSetOperation;
165165
import org.apache.doris.nereids.trees.plans.logical.LogicalTopN;
166+
import org.apache.doris.nereids.trees.plans.logical.LogicalUnion;
166167
import org.apache.doris.nereids.trees.plans.logical.LogicalWindow;
167168

168169
import com.google.common.collect.ImmutableList;
@@ -412,7 +413,9 @@ public class Rewriter extends AbstractBatchJobExecutor {
412413
topDown(new EliminateJoinByUnique())
413414
),
414415
topic("eliminate Aggregate according to fd items",
415-
cascadesContext -> cascadesContext.rewritePlanContainsTypes(LogicalAggregate.class),
416+
cascadesContext -> cascadesContext.rewritePlanContainsTypes(LogicalAggregate.class)
417+
|| cascadesContext.rewritePlanContainsTypes(LogicalJoin.class)
418+
|| cascadesContext.rewritePlanContainsTypes(LogicalUnion.class),
416419
custom(RuleType.ELIMINATE_GROUP_BY_KEY_BY_UNIFORM, EliminateGroupByKeyByUniform::new),
417420
topDown(new EliminateGroupByKey()),
418421
topDown(new PushDownAggThroughJoinOnPkFk()),

fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/InferFilterNotNull.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import org.apache.doris.nereids.trees.expressions.Expression;
2323
import org.apache.doris.nereids.trees.expressions.Not;
2424
import org.apache.doris.nereids.trees.plans.Plan;
25-
import org.apache.doris.nereids.trees.plans.algebra.Join;
2625
import org.apache.doris.nereids.trees.plans.logical.LogicalFilter;
2726
import org.apache.doris.nereids.util.ExpressionUtils;
2827
import org.apache.doris.nereids.util.PlanUtils;
@@ -55,9 +54,6 @@ public Rule build() {
5554
return true;
5655
})
5756
.thenApply(ctx -> {
58-
if (!ctx.cascadesContext.getRewritePlan().containsType(Join.class)) {
59-
return ctx.root;
60-
}
6157
LogicalFilter<Plan> filter = ctx.root;
6258
Set<Expression> predicates = filter.getConjuncts();
6359
Set<Expression> isNotNulls = ExpressionUtils.inferNotNull(predicates, ctx.cascadesContext);

0 commit comments

Comments
 (0)