Skip to content

[refactor](decimal) Re-construct ColumnDecimal #51480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

Gabriel39
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jun 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33791 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 889d281688ce2d127901abb5647b34f38b5d287d, data reload: false

------ Round 1 ----------------------------------
q1	26137	5152	5053	5053
q2	1966	315	178	178
q3	10403	1287	693	693
q4	10228	997	542	542
q5	7669	2419	2309	2309
q6	183	160	128	128
q7	902	717	588	588
q8	9294	1274	1090	1090
q9	6825	5105	5097	5097
q10	6802	2324	1874	1874
q11	506	285	271	271
q12	349	352	212	212
q13	17770	3669	3068	3068
q14	229	223	210	210
q15	570	475	497	475
q16	430	427	369	369
q17	586	865	357	357
q18	7850	7235	7173	7173
q19	1484	948	550	550
q20	322	333	228	228
q21	3674	3152	2363	2363
q22	1014	1007	963	963
Total cold run time: 115193 ms
Total hot run time: 33791 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5097	5053	5077	5053
q2	239	324	220	220
q3	2154	2677	2280	2280
q4	1325	1750	1345	1345
q5	4544	4434	4410	4410
q6	219	170	125	125
q7	1960	1892	1732	1732
q8	2593	2674	2581	2581
q9	7307	7108	7236	7108
q10	2980	3148	2705	2705
q11	583	497	490	490
q12	674	779	591	591
q13	3472	3952	3317	3317
q14	274	309	274	274
q15	514	468	470	468
q16	459	494	466	466
q17	1124	1518	1400	1400
q18	7760	7687	7421	7421
q19	843	908	1048	908
q20	1965	2013	1826	1826
q21	4772	4291	4226	4226
q22	1071	1030	999	999
Total cold run time: 51929 ms
Total hot run time: 49945 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186114 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 889d281688ce2d127901abb5647b34f38b5d287d, data reload: false

query1	1012	478	494	478
query2	6571	1936	1904	1904
query3	6779	224	223	223
query4	26170	23584	23485	23485
query5	4363	615	465	465
query6	297	210	189	189
query7	4616	487	276	276
query8	253	218	224	218
query9	8659	2652	2682	2652
query10	474	349	278	278
query11	15144	15001	14801	14801
query12	159	114	106	106
query13	1663	532	408	408
query14	8767	6150	6096	6096
query15	197	193	171	171
query16	7143	634	454	454
query17	1008	733	594	594
query18	1970	399	309	309
query19	196	191	164	164
query20	122	116	112	112
query21	220	125	107	107
query22	4251	4319	4158	4158
query23	34063	33042	33116	33042
query24	8440	2444	2330	2330
query25	535	454	383	383
query26	1260	265	149	149
query27	2757	493	335	335
query28	4343	2128	2108	2108
query29	770	543	440	440
query30	277	220	233	220
query31	890	854	756	756
query32	72	68	59	59
query33	567	370	317	317
query34	792	837	515	515
query35	773	822	732	732
query36	913	953	878	878
query37	110	102	77	77
query38	4049	4179	4012	4012
query39	1477	1394	1411	1394
query40	215	117	104	104
query41	61	58	59	58
query42	124	106	103	103
query43	503	514	486	486
query44	1305	814	828	814
query45	176	170	168	168
query46	828	1011	636	636
query47	1753	1829	1760	1760
query48	370	417	313	313
query49	739	467	392	392
query50	640	676	391	391
query51	4051	4192	4090	4090
query52	114	105	103	103
query53	214	256	182	182
query54	575	565	501	501
query55	81	84	81	81
query56	304	281	311	281
query57	1139	1156	1092	1092
query58	257	249	255	249
query59	2666	2775	2685	2685
query60	329	323	304	304
query61	135	128	122	122
query62	805	711	659	659
query63	216	190	183	183
query64	4394	1012	681	681
query65	4249	4115	4121	4115
query66	1146	462	327	327
query67	16002	15604	15466	15466
query68	8438	872	515	515
query69	475	311	271	271
query70	1182	1114	1098	1098
query71	502	335	310	310
query72	5299	4733	4692	4692
query73	716	605	345	345
query74	8851	8974	8801	8801
query75	3947	3196	2678	2678
query76	3687	1182	740	740
query77	795	366	296	296
query78	10007	10392	9400	9400
query79	1994	861	554	554
query80	752	516	445	445
query81	468	261	217	217
query82	425	128	104	104
query83	295	249	235	235
query84	297	115	90	90
query85	786	369	329	329
query86	355	307	275	275
query87	4388	4450	4402	4402
query88	3281	2249	2280	2249
query89	388	315	289	289
query90	1930	216	212	212
query91	144	161	113	113
query92	77	58	56	56
query93	1430	939	572	572
query94	686	418	300	300
query95	371	285	277	277
query96	489	571	277	277
query97	2754	2745	2703	2703
query98	254	217	217	217
query99	1478	1423	1311	1311
Total cold run time: 272454 ms
Total hot run time: 186114 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.05 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 889d281688ce2d127901abb5647b34f38b5d287d, data reload: false

query1	0.04	0.03	0.03
query2	0.12	0.11	0.10
query3	0.25	0.20	0.19
query4	1.59	0.19	0.20
query5	0.44	0.43	0.43
query6	1.16	0.66	0.65
query7	0.02	0.01	0.02
query8	0.04	0.03	0.04
query9	0.58	0.53	0.52
query10	0.58	0.58	0.57
query11	0.15	0.11	0.11
query12	0.15	0.11	0.11
query13	0.60	0.61	0.60
query14	0.79	0.80	0.80
query15	0.88	0.86	0.86
query16	0.39	0.38	0.38
query17	1.03	1.05	1.01
query18	0.22	0.21	0.20
query19	1.98	1.78	1.83
query20	0.01	0.01	0.01
query21	15.41	0.91	0.53
query22	0.75	1.19	0.67
query23	15.01	1.37	0.66
query24	7.45	0.85	0.87
query25	0.67	0.26	0.09
query26	0.63	0.17	0.15
query27	0.05	0.05	0.05
query28	9.90	0.93	0.43
query29	12.53	3.98	3.32
query30	0.26	0.10	0.07
query31	2.81	0.61	0.38
query32	3.24	0.54	0.46
query33	3.00	3.04	3.01
query34	15.86	5.09	4.50
query35	4.48	4.50	4.51
query36	0.68	0.49	0.49
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.03
query40	0.16	0.14	0.12
query41	0.08	0.02	0.03
query42	0.03	0.02	0.03
query43	0.05	0.03	0.04
Total cold run time: 104.24 s
Total hot run time: 29.05 s

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33889 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4eb9a4dc0a6f22254ef7f3c697524860009dadf7, data reload: false

------ Round 1 ----------------------------------
q1	26283	5055	5018	5018
q2	1968	292	188	188
q3	10394	1246	700	700
q4	10234	988	539	539
q5	7664	2366	2360	2360
q6	184	163	130	130
q7	933	712	623	623
q8	9320	1525	1099	1099
q9	6795	5110	5088	5088
q10	6874	2326	1935	1935
q11	485	282	286	282
q12	347	348	222	222
q13	17799	3657	3038	3038
q14	230	233	206	206
q15	560	499	489	489
q16	421	431	383	383
q17	609	857	367	367
q18	7578	7205	7083	7083
q19	1669	954	566	566
q20	325	336	225	225
q21	3756	3186	2363	2363
q22	1023	1018	985	985
Total cold run time: 115451 ms
Total hot run time: 33889 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5200	5005	5061	5005
q2	240	314	227	227
q3	2153	2704	2244	2244
q4	1337	1791	1347	1347
q5	4455	4396	4402	4396
q6	219	166	133	133
q7	2037	1894	1726	1726
q8	2565	2605	2528	2528
q9	7239	7301	6948	6948
q10	2993	3211	2777	2777
q11	580	522	484	484
q12	677	783	608	608
q13	3513	3865	3230	3230
q14	281	310	294	294
q15	560	514	521	514
q16	439	476	444	444
q17	1159	1731	1347	1347
q18	7841	7644	7478	7478
q19	819	847	1009	847
q20	1990	2031	1949	1949
q21	4804	4331	4474	4331
q22	1103	1051	1041	1041
Total cold run time: 52204 ms
Total hot run time: 49898 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192386 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4eb9a4dc0a6f22254ef7f3c697524860009dadf7, data reload: false

query1	1408	1081	1035	1035
query2	6294	1833	1826	1826
query3	11120	4735	4616	4616
query4	25711	23759	23241	23241
query5	4286	639	459	459
query6	309	217	207	207
query7	3991	504	290	290
query8	269	239	220	220
query9	8527	2690	2662	2662
query10	489	337	271	271
query11	15206	15062	14844	14844
query12	159	116	106	106
query13	1555	534	417	417
query14	8709	6131	6010	6010
query15	201	197	169	169
query16	7257	676	458	458
query17	1170	732	548	548
query18	1958	417	314	314
query19	200	204	168	168
query20	132	126	123	123
query21	211	135	116	116
query22	4549	4702	4483	4483
query23	34650	33819	33662	33662
query24	8690	2412	2413	2412
query25	558	462	394	394
query26	1194	271	155	155
query27	3159	510	333	333
query28	4753	2187	2159	2159
query29	737	566	449	449
query30	272	219	192	192
query31	922	887	800	800
query32	76	63	64	63
query33	532	388	304	304
query34	833	890	536	536
query35	787	835	757	757
query36	953	988	894	894
query37	123	101	83	83
query38	4224	4332	4184	4184
query39	1534	1462	1473	1462
query40	213	116	104	104
query41	60	58	57	57
query42	125	127	114	114
query43	506	507	477	477
query44	1365	844	838	838
query45	183	182	164	164
query46	847	1026	663	663
query47	1848	1927	1767	1767
query48	395	427	325	325
query49	769	487	406	406
query50	682	713	420	420
query51	4311	4221	4166	4166
query52	117	115	102	102
query53	229	253	194	194
query54	588	622	515	515
query55	88	86	85	85
query56	327	317	296	296
query57	1145	1193	1129	1129
query58	290	279	281	279
query59	2624	2743	2603	2603
query60	367	350	331	331
query61	148	155	147	147
query62	782	751	687	687
query63	229	192	192	192
query64	4344	1067	687	687
query65	4413	4279	4303	4279
query66	1088	402	301	301
query67	16081	15622	15333	15333
query68	8265	915	532	532
query69	467	301	272	272
query70	1209	1135	1136	1135
query71	468	339	302	302
query72	5761	4743	4747	4743
query73	697	625	360	360
query74	8924	8910	8737	8737
query75	3921	3202	2708	2708
query76	3720	1196	750	750
query77	779	371	285	285
query78	10070	10136	9361	9361
query79	2552	807	596	596
query80	698	497	423	423
query81	473	260	220	220
query82	419	125	93	93
query83	279	244	241	241
query84	288	110	89	89
query85	760	348	313	313
query86	334	309	276	276
query87	4429	4396	4328	4328
query88	3400	2279	2263	2263
query89	392	316	293	293
query90	1904	204	209	204
query91	138	145	117	117
query92	141	66	59	59
query93	1882	917	578	578
query94	657	407	311	311
query95	380	292	284	284
query96	498	576	282	282
query97	2743	2788	2635	2635
query98	220	223	220	220
query99	1453	1410	1293	1293
Total cold run time: 280193 ms
Total hot run time: 192386 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.04 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4eb9a4dc0a6f22254ef7f3c697524860009dadf7, data reload: false

query1	0.03	0.04	0.03
query2	0.13	0.10	0.11
query3	0.26	0.19	0.20
query4	1.59	0.20	0.12
query5	0.42	0.42	0.44
query6	1.17	0.66	0.65
query7	0.03	0.02	0.01
query8	0.05	0.04	0.03
query9	0.58	0.51	0.51
query10	0.58	0.59	0.57
query11	0.15	0.11	0.12
query12	0.15	0.12	0.11
query13	0.61	0.62	0.59
query14	0.78	0.80	0.81
query15	0.87	0.87	0.86
query16	0.39	0.39	0.38
query17	1.00	1.02	1.03
query18	0.23	0.21	0.21
query19	1.99	1.77	1.87
query20	0.02	0.01	0.01
query21	15.40	0.90	0.54
query22	0.76	1.20	0.64
query23	14.91	1.36	0.64
query24	7.21	1.39	0.94
query25	0.48	0.25	0.07
query26	0.64	0.17	0.13
query27	0.05	0.05	0.05
query28	9.00	0.89	0.45
query29	12.57	3.96	3.28
query30	0.26	0.09	0.06
query31	2.82	0.58	0.38
query32	3.22	0.55	0.48
query33	3.04	3.03	3.10
query34	15.76	5.15	4.52
query35	4.54	4.52	4.55
query36	0.67	0.50	0.49
query37	0.08	0.06	0.07
query38	0.06	0.04	0.03
query39	0.04	0.03	0.03
query40	0.17	0.14	0.13
query41	0.09	0.03	0.02
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 102.88 s
Total hot run time: 29.04 s

Copy link
Contributor

github-actions bot commented Jun 5, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 5, 2025
Copy link
Contributor

github-actions bot commented Jun 5, 2025

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 1e3cacd into apache:master Jun 5, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants