Skip to content

Commit fc41218

Browse files
committed
[MPLUGIN-498] Move section rendering to separate methods
This closes #248
1 parent ed4774b commit fc41218

File tree

1 file changed

+18
-9
lines changed

1 file changed

+18
-9
lines changed

maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginOverviewRenderer.java

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -87,15 +87,28 @@ protected void renderBody() {
8787
return;
8888
}
8989

90-
paragraph(getI18nString("goals.intro"));
91-
9290
boolean hasMavenReport = false;
9391
for (MojoDescriptor mojo : pluginDescriptor.getMojos()) {
9492
if (PluginUtils.isMavenReport(mojo.getImplementation(), project)) {
9593
hasMavenReport = true;
94+
break;
9695
}
9796
}
9897

98+
renderGoalsSection(hasMavenReport);
99+
100+
renderSystemRequirementsSection();
101+
102+
renderRequirementsHistoriesSection();
103+
104+
renderUsageSection(hasMavenReport);
105+
106+
endSection();
107+
}
108+
109+
private void renderGoalsSection(boolean hasMavenReport) {
110+
paragraph(getI18nString("goals.intro"));
111+
99112
startTable();
100113

101114
String goalColumnName = getI18nString("goals.column.goal");
@@ -144,7 +157,9 @@ protected void renderBody() {
144157
}
145158

146159
endTable();
160+
}
147161

162+
private void renderSystemRequirementsSection() {
148163
startSection(getI18nString("systemrequirements"));
149164

150165
paragraph(getI18nString("systemrequirements.intro"));
@@ -166,15 +181,9 @@ protected void renderBody() {
166181
endTable();
167182

168183
endSection();
169-
170-
renderRequirementsHistories();
171-
172-
renderUsageSection(hasMavenReport);
173-
174-
endSection();
175184
}
176185

177-
private void renderRequirementsHistories() {
186+
private void renderRequirementsHistoriesSection() {
178187
if (requirementsHistories.isEmpty()) {
179188
return;
180189
}

0 commit comments

Comments
 (0)