Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Commit e831037

Browse files
authored
Move System.Data.SqlClient version from csproj to dependencies.props (#303)
1 parent f5345a2 commit e831037

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

build/dependencies.props

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
11
<Project>
22
<PropertyGroup>
33
<AspNetCoreVersion>2.0.0-preview1-*</AspNetCoreVersion>
4+
5+
<!--
6+
* Use 4.4.0-* instead of $(CoreFxVersion) to address "SqlClient fails with netcoreapp2.0 on Win7/Server2008"
7+
* https://github.com/dotnet/corefx/issues/18406
8+
* Revert if and when $(CoreFxVersion) is upgraded to 4.4.0-*
9+
-->
10+
<SqlClientVersion>4.4.0-*</SqlClientVersion>
11+
412
<CoreFxVersion>4.3.0</CoreFxVersion>
513
<InternalAspNetCoreSdkVersion>2.0.0-*</InternalAspNetCoreSdkVersion>
614
<MoqVersion>4.7.1</MoqVersion>

src/Microsoft.Extensions.Caching.SqlServer/Microsoft.Extensions.Caching.SqlServer.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@
2323

2424
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.2' ">
2525
<!--
26-
* Use 4.4.0-* instead of $(CoreFxVersion) to address "SqlClient fails with netcoreapp2.0 on Win7/Server2008"
26+
* Use $(SqlClientVersion) instead of $(CoreFxVersion) to address "SqlClient fails with netcoreapp2.0 on Win7/Server2008"
2727
* https://github.com/dotnet/corefx/issues/18406
28-
* Revert if and when $(CoreFxVersion) is upgraded to 4.4.0-*
28+
* Revert if and when $(CoreFxVersion) is upgraded to match $(SqlClientVersion)
2929
-->
30-
<PackageReference Include="System.Data.SqlClient" Version="4.4.0-*" />
30+
<PackageReference Include="System.Data.SqlClient" Version="$(SqlClientVersion)" />
3131
</ItemGroup>
3232

3333
</Project>

0 commit comments

Comments
 (0)