-
Notifications
You must be signed in to change notification settings - Fork 94
typings: createInstance should return constructor function #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, that looks good. Better than what we have now at least. Unfortunately it doesn't work with the helper components: Please create a PR. Would be great if you can fix the static members as well. I've struggled with typing these in the past and I'm still not comfortable with creating types for that kind of thing. |
It's not about the |
@harbeedev Will you create a pull request? Let's ignore the subcomponents for now, hopefully somebody will come up with a fix for that. |
Fixed in v7.0.4 |
Hi, I believe the typescript signature of
createInstance
should be:I have tested this locally, and I'm happy to create a pull request if needed.
The text was updated successfully, but these errors were encountered: