Skip to content

refactor for python websocket client #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Adi-204 opened this issue Apr 28, 2025 · 2 comments · May be fixed by #1572
Open

refactor for python websocket client #1517

Adi-204 opened this issue Apr 28, 2025 · 2 comments · May be fixed by #1572

Comments

@Adi-204
Copy link
Contributor

Adi-204 commented Apr 28, 2025

Currently inside method - async def send_message_static(message, socket): the line await HoppscotchEchoWebSocketClient._send(message, socket) is written which means for all the generated client HoppscotchEchoWebSocketClient will be written but we need it to be dynamic and extract from asyncapi document.

For ref -

generator/packages/templates/clients/websocket/python/components/SendEchoMessage.js

Line 31 in 20d10dc

await HoppscotchEchoWebSocketClient._send(message, socket)

@derberg derberg moved this to Todo in Maintainers work Apr 30, 2025
@Aditya08Vashisht
Copy link
Contributor

Aditya08Vashisht commented May 6, 2025 •
edited
Loading

Hey! @derberg , @Adi-204
I’ve been digging into it and saw that the referenced file SendEchoMessage.js seems to have moved away from the async/static structure mentioned in the description. It now uses a more processor-based synchronous approach.

Totally understand if it's being handled internally, but I’d love to contribute or help validate/test any upcoming changes if you’re open to collaboration... as my previous issues has been done from my side so I'm currently exploring the generator's Python WebSocket client internals which i was intrested from the very starting and would be happy to assist where useful.

Either way—really enjoying diving into the codebase overall! 🚀

@Adi-204
Copy link
Contributor Author

Adi-204 commented May 21, 2025

@derberg I am working on this issue.

@Adi-204 Adi-204 linked a pull request May 21, 2025 that will close this issue
Open
@derberg derberg moved this from Todo to In Progress in Maintainers work May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Maintainers work
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: replace hardcode sendEchoMessage method in py websocket client Adi-204/generator
2 participants
@Adi-204 @Aditya08Vashisht