Skip to content

Commit 53e0588

Browse files
edsantiagocevich
authored andcommitted
Skip failing tests on docker 1.10 (#641)
BZ#1330224 will never be fixed in 1.10 It causes failures in docker-1.10 but is fixed in 1.12 (it was never a problem pre-1.10). The bug will not be fixed in any RH build of docker-1.10, so let's just skip it when encountered. Signed-off-by: Ed Santiago <[email protected]>
1 parent 03c0290 commit 53e0588

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

subtests/docker_cli/start/long_term_app.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ class long_term_app(short_term_app):
2222

2323
def initialize(self):
2424
super(long_term_app, self).initialize()
25+
self.skip_if_docker_1_10()
2526
kill_cmd = DockerCmd(self, "kill",
2627
[self.sub_stuff["container"].long_id],
2728
self.config['docker_run_timeout'])

subtests/docker_cli/start/rerun_long_term_app.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ class rerun_long_term_app(short_term_app):
1616
config_section = 'docker_cli/start/rerun_long_term_app'
1717
check_if_cmd_finished = False
1818

19+
def initialize(self):
20+
super(rerun_long_term_app, self).initialize()
21+
self.skip_if_docker_1_10()
22+
1923
def outputgood(self):
2024
# Raise exception if problems found
2125
# but ignore expected error message

subtests/docker_cli/start/start.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
from dockertest.output import OutputGood
2424
from dockertest.dockercmd import AsyncDockerCmd, DockerCmd
2525
from dockertest.containers import DockerContainers
26+
from dockertest.output import DockerVersion
27+
from dockertest.xceptions import DockerTestNAError
2628
from dockertest.images import DockerImage
2729
from dockertest import subtest
2830
from dockertest import config
@@ -124,6 +126,11 @@ def wait_for_container_death(self, container_obj):
124126
results = prep_changes.execute()
125127
return results.exit_status
126128

129+
@staticmethod
130+
def skip_if_docker_1_10():
131+
if DockerVersion().server.startswith("1.10"):
132+
raise DockerTestNAError("rhbz#1330224 will not be fixed in 1.10")
133+
127134

128135
class short_term_app(start_base):
129136
config_section = 'docker_cli/start/short_term_app'

0 commit comments

Comments
 (0)