Skip to content

Commit aaae76b

Browse files
committed
add by default
1 parent 71ecc2f commit aaae76b

File tree

3 files changed

+8
-14
lines changed

3 files changed

+8
-14
lines changed

pkg/generate/ack/release.go

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"github.com/aws-controllers-k8s/code-generator/pkg/generate/templateset"
2222
ackmetadata "github.com/aws-controllers-k8s/code-generator/pkg/metadata"
2323
ackmodel "github.com/aws-controllers-k8s/code-generator/pkg/model"
24+
"github.com/aws-controllers-k8s/pkg/names"
2425
)
2526

2627
var (
@@ -103,16 +104,9 @@ func Release(
103104
releaseFuncMap(m.MetaVars().ControllerName),
104105
)
105106
metaVars := m.MetaVars()
106-
107-
crds, err := m.GetCRDs()
108-
if err != nil {
109-
return nil, err
110-
}
111-
112-
reconcileResources := make([]string, 0)
113-
114-
for _, crd := range crds {
115-
reconcileResources = append(reconcileResources, crd.Names.Camel)
107+
reconcileResources := make([]string, len(metaVars.CRDNames))
108+
for i, name := range metaVars.CRDNames {
109+
reconcileResources[i] = names.New(name).Camel
116110
}
117111

118112
releaseVars := &templateReleaseVars{

templates/helm/values.schema.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,8 @@
245245
"items": {
246246
"type": "string"
247247
},
248-
"description": "List of resource kinds to reconcile. If empty, all resources will be reconciled."
248+
"description": "List of resource kinds to reconcile. If empty, all resources will be reconciled.",
249+
"default": []
249250
}
250251
},
251252
"type": "object"

templates/helm/values.yaml.tpl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,10 +141,9 @@ reconcile:
141141
# Set the value of resources to specify which resource kinds to reconcile.
142142
# If empty, all resources will be reconciled.
143143
# If specified, only the listed resource kinds will be reconciled.
144-
resources: []
145-
# Available resource kinds for this controller:
144+
resources:
146145
{{- range $resource := .ReconcileResources }}
147-
# - {{ $resource }}
146+
- {{ $resource }}
148147
{{- end }}
149148

150149
serviceAccount:

0 commit comments

Comments
 (0)