refactor: remove additional uses of reflection for CBOR decoding (#986)

Signed-off-by: Aurora Gaffney <[email protected]>

Author: agaffney

ledger/alonzo/alonzo.go

@@ -269,8 +269,6 @@ type AlonzoTransactionOutput struct {
 }
 
 func (o *AlonzoTransactionOutput) UnmarshalCBOR(cborData []byte) error {
-	// Save original CBOR
-	o.SetCbor(cborData)
 	// Try to parse as legacy mary.Mary output first
 	var tmpOutput mary.MaryTransactionOutput
 	if _, err := cbor.Decode(cborData, &tmpOutput); err == nil {
@@ -279,8 +277,15 @@ func (o *AlonzoTransactionOutput) UnmarshalCBOR(cborData []byte) error {
 		o.OutputAmount = tmpOutput.OutputAmount
 		o.legacyOutput = true
 	} else {
-		return cbor.DecodeGeneric(cborData, o)
+		type tAlonzoTransactionOutput AlonzoTransactionOutput
+		var tmp tAlonzoTransactionOutput
+		if _, err := cbor.Decode(cborData, &tmp); err != nil {
+			return err
+		}
+		*o = AlonzoTransactionOutput(tmp)
 	}
+	// Save original CBOR
+	o.SetCbor(cborData)
 	return nil
 }
 

ledger/babbage/babbage.go

@@ -435,7 +435,12 @@ func (o *BabbageTransactionOutput) UnmarshalCBOR(cborData []byte) error {
 		o.OutputAmount = tmpOutput.OutputAmount
 		o.legacyOutput = true
 	} else {
-		return cbor.DecodeGeneric(cborData, o)
+		type tBabbageTransactionOutput BabbageTransactionOutput
+		var tmp tBabbageTransactionOutput
+		if _, err := cbor.Decode(cborData, &tmp); err != nil {
+			return err
+		}
+		*o = BabbageTransactionOutput(tmp)
 	}
 	return nil
 }

ledger/byron/byron.go

@@ -337,6 +337,7 @@ func (i *ByronTransactionInput) UnmarshalCBOR(data []byte) error {
 	}
 	switch id {
 	case 0:
+		// Decode outer data
 		var tmpData struct {
 			cbor.StructAsArray
 			Id   int
@@ -345,9 +346,13 @@ func (i *ByronTransactionInput) UnmarshalCBOR(data []byte) error {
 		if _, err := cbor.Decode(data, &tmpData); err != nil {
 			return err
 		}
-		if err := cbor.DecodeGeneric(tmpData.Cbor, i); err != nil {
+		// Decode inner data
+		type tByronTransactionInput ByronTransactionInput
+		var tmp tByronTransactionInput
+		if _, err := cbor.Decode(tmpData.Cbor, &tmp); err != nil {
 			return err
 		}
+		*i = ByronTransactionInput(tmp)
 	default:
 		// [u8 .ne 0, encoded-cbor]
 		return errors.New("can't parse yet")

ledger/common/nonce.go

@@ -45,9 +45,12 @@ func (n *Nonce) UnmarshalCBOR(data []byte) error {
 	case NonceTypeNeutral:
 		// Value uses default value
 	case NonceTypeNonce:
-		if err := cbor.DecodeGeneric(data, n); err != nil {
+		type tNonce Nonce
+		var tmp tNonce
+		if _, err := cbor.Decode(data, &tmp); err != nil {
 			return err
 		}
+		*n = Nonce(tmp)
 	default:
 		return fmt.Errorf("unsupported nonce type %d", nonceType)
 	}

ledger/mary/mary.go

@@ -471,12 +471,16 @@ type MaryTransactionOutputValue struct {
 }
 
 func (v *MaryTransactionOutputValue) UnmarshalCBOR(data []byte) error {
+	// Try to decode as simple amount first
 	if _, err := cbor.Decode(data, &(v.Amount)); err == nil {
 		return nil
 	}
-	if err := cbor.DecodeGeneric(data, v); err != nil {
+	type tMaryTransactionOutputValue MaryTransactionOutputValue
+	var tmp tMaryTransactionOutputValue
+	if _, err := cbor.Decode(data, &tmp); err != nil {
 		return err
 	}
+	*v = MaryTransactionOutputValue(tmp)
 	return nil
 }
 

protocol/chainsync/messages.go

@@ -144,9 +144,14 @@ func NewMsgRollForwardNtC(
 }
 
 func (m *MsgRollForwardNtC) UnmarshalCBOR(data []byte) error {
-	if err := cbor.DecodeGeneric(data, m); err != nil {
+	// Decode message
+	type tMsgRollForwardNtC MsgRollForwardNtC
+	var tmp tMsgRollForwardNtC
+	if _, err := cbor.Decode(data, &tmp); err != nil {
 		return err
 	}
+	*m = MsgRollForwardNtC(tmp)
+	// Decode wrapped block
 	var wb WrappedBlock
 	if _, err := cbor.Decode(m.WrappedBlock.Content.([]byte), &wb); err != nil {
 		return err

protocol/localstatequery/queries.go

@@ -525,7 +525,12 @@ func (u *UtxoId) UnmarshalCBOR(data []byte) error {
 		u.Hash = tmpData.Hash
 		u.Idx = tmpData.Idx
 	case 3:
-		return cbor.DecodeGeneric(data, u)
+		type tUtxoId UtxoId
+		var tmp tUtxoId
+		if _, err := cbor.Decode(data, &tmp); err != nil {
+			return err
+		}
+		*u = UtxoId(tmp)
 	default:
 		return fmt.Errorf("invalid list length: %d", listLen)
 	}