New reinstall binary - warning?

[omertuc]

Do we want the:

----------------------------
WARNING: This operation will OVERWRITE THE BOOTED HOST ROOT FILESYSTEM and is NOT REVERSIBLE.
Waiting 20s to continue; interrupt (Control-C) to cancel.
----------------------------

prompt when the user uses our new reinstall binary (BIFROST-610)? Or should we default to --acknowledge-destructive?

[omertuc]

My opinion is that since the new binary is specifically meant for reinstalling the system, and it's no longer a long and arcane podman run bootc invocation (that the user might not know the consequences of), I think we can safely implicitly add --acknowledge-destructive to remove the prompt.

But obviously I still think this needs to be discussed

[cgwalters]

I think we can safely implicitly add --acknowledge-destructive to remove the prompt.

Agreed.

We can also consider entirely new warnings for the reinstall script, maybe even a y/n prompt at the binary level rather than relying on bootc itself for providing the prompt

Yep.

[omertuc]

We can also consider entirely new warnings for the reinstall script, maybe even a y/n prompt at the binary level rather than relying on bootc itself for providing the prompt

[omertuc]

We should also consider how this will interact with the future SSH key / user management related TUI / prompts. If we're gonna prompt the user anyway for the SSH stuff, might as well have something like "WARNING: YOUR SYSTEM WILL BE REINSTALLED followed by <some SSH key related prompt>".

As to avoid asking the user too many questions

[ckyrouac]

IMO, I think the final user input that triggers the reinstall should require something like entering the system's hostname, or typing out "REINSTALL". I'd also like to add a --dry-run flag for devs to prevent accidentally overwriting my system.