Skip to content

Commit 67fdf59

Browse files
sg00dwincdcabrera
authored andcommitted
Move 'view details' link into it's own container that can wrap at mobile.
Some adjustments needed for vertical alignment. Reference openshift#2182
1 parent 65b96ce commit 67fdf59

File tree

4 files changed

+28
-14
lines changed

4 files changed

+28
-14
lines changed

app/styles/_kve.less

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@
118118
.key-value-editor-entry,
119119
.environment-from-entry {
120120
display: table;
121+
margin-bottom: 15px;
121122
padding-right: (@as-sortable-item-button-width * 2);
122123
position: relative;
123124
table-layout: fixed;
@@ -127,11 +128,12 @@
127128
float: left;
128129
padding-right: 5px;
129130
position: relative;
130-
width: 50%;
131+
width: auto;
131132
}
132133
}
133134
.environment-from-input {
134135
float: left;
136+
margin-bottom: 0;
135137
padding-right: 5px;
136138
width: 100%;
137139
@media(min-width: @screen-md-min) {
@@ -144,6 +146,13 @@
144146
}
145147
}
146148
}
149+
.environment-from-entry {
150+
.environment-from-view-details {
151+
float: left;
152+
line-height: 1;
153+
padding: 6px 0 0;
154+
}
155+
}
147156

148157
.key-value-editor-input .ui-select {
149158
@media(min-width: @screen-md-min) {
@@ -163,6 +172,7 @@
163172
.key-value-editor .key-value-editor-input,
164173
.key-value-editor-header {
165174
float: left;
175+
margin-bottom: 0;
166176
padding-right: 5px;
167177
width: 50%;
168178
}

app/views/directives/edit-environment-from.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,12 @@
6767
role="button"
6868
aria-label="Delete row"
6969
ng-click="$ctrl.deleteEntry($index, 1)"></a>
70+
</div>
71+
<div class="environment-from-view-details">
7072
<a
7173
ng-if="entry.selectedEnvFrom"
7274
href=""
73-
ng-click="$ctrl.viewOverlayPanel(entry.selectedEnvFrom)"
74-
class="pficon">View Details</a>
75+
ng-click="$ctrl.viewOverlayPanel(entry.selectedEnvFrom)">View Details</a>
7576
</div>
7677
</div>
7778

dist/scripts/templates.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6638,7 +6638,9 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
66386638
"<div ng-if=\"!$ctrl.isReadonlyAny && !entry.isReadonlyValue\" class=\"environment-from-editor-button\">\n" +
66396639
"<span ng-if=\"!$ctrl.cannotSort && $ctrl.entries.length > 1\" class=\"fa fa-bars sort-row\" role=\"button\" aria-label=\"Move row\" aria-grabbed=\"false\" as-sortable-item-handle></span>\n" +
66406640
"<a ng-if=\"!$ctrl.cannotDeleteAny\" href=\"\" class=\"pficon pficon-close delete-row as-sortable-item-delete\" role=\"button\" aria-label=\"Delete row\" ng-click=\"$ctrl.deleteEntry($index, 1)\"></a>\n" +
6641-
"<a ng-if=\"entry.selectedEnvFrom\" href=\"\" ng-click=\"$ctrl.viewOverlayPanel(entry.selectedEnvFrom)\" class=\"pficon\">View Details</a>\n" +
6641+
"</div>\n" +
6642+
"<div class=\"environment-from-view-details\">\n" +
6643+
"<a ng-if=\"entry.selectedEnvFrom\" href=\"\" ng-click=\"$ctrl.viewOverlayPanel(entry.selectedEnvFrom)\">View Details</a>\n" +
66426644
"</div>\n" +
66436645
"</div>\n" +
66446646
"<div class=\"environment-from-entry form-group\" ng-if=\"!$ctrl.cannotAdd\">\n" +

dist/styles/main.css

Lines changed: 11 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)