Address review feedback

jasnell · jasnell · commit c32c8bae57d9 · 2025-02-10T08:48:57.000-08:00
diff --git a/src/workerd/api/crypto/jwk.c++ b/src/workerd/api/crypto/jwk.c++
@@ -26,7 +26,6 @@ kj::String getCurveName(int nid) {
     default:
       return kj::String();
   }
-  KJ_UNREACHABLE;
 }
 
 int getCurveFromName(kj::StringPtr name) {
@@ -284,6 +283,7 @@ JsonWebKey toJwk(const EVPKeyPointer& key, KeyType keyType) {
         return jwkFromRsaKey(key, keyType);
       case EVP_PKEY_DSA: {
         // DSA keys are not supported for JWK export.
+        break;
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@ kj::String getCurveName(int nid) {`
`26`	`26`	`default:`
`27`	`27`	`return kj::String();`
`28`	`28`	`}`
`29`		`- KJ_UNREACHABLE;`
`30`	`29`	`}`
`31`	`30`
`32`	`31`	`int getCurveFromName(kj::StringPtr name) {`
`@@ -284,6 +283,7 @@ JsonWebKey toJwk(const EVPKeyPointer& key, KeyType keyType) {`
`284`	`283`	`return jwkFromRsaKey(key, keyType);`
`285`	`284`	`case EVP_PKEY_DSA: {`
`286`	`285`	`// DSA keys are not supported for JWK export.`
	`286`	`+ break;`
`287`	`287`	`}`
`288`	`288`	`}`
`289`	`289`	`}`