Skip to content

Commit f0a45e6

Browse files
committed
Add tests for Memory<byte>?
1 parent a6a6912 commit f0a45e6

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

src/Confluent.Kafka/Producer.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -791,7 +791,7 @@ public async Task<DeliveryResult<TKey, TValue>> ProduceAsync(
791791
{
792792
keyBytes = readOnlyMemory;
793793
}
794-
else // Nullable Memory<byte>
794+
else // Null Memory<byte>?
795795
{
796796
keyBytes = null;
797797
}
@@ -829,7 +829,7 @@ public async Task<DeliveryResult<TKey, TValue>> ProduceAsync(
829829
{
830830
valBytes = readOnlyMemory;
831831
}
832-
else // Nullable Memory<byte>
832+
else // Null Memory<byte>?
833833
{
834834
valBytes = null;
835835
}
@@ -951,7 +951,7 @@ public void Produce(
951951
{
952952
keyBytes = readOnlyMemory;
953953
}
954-
else // Nullable Memory<byte>
954+
else // Null Memory<byte>?
955955
{
956956
keyBytes = null;
957957
}
@@ -988,7 +988,7 @@ public void Produce(
988988
{
989989
valBytes = readOnlyMemory;
990990
}
991-
else // Nullable Memory<byte>
991+
else // Null Memory<byte>?
992992
{
993993
valBytes = null;
994994
}

test/Confluent.Kafka.IntegrationTests/Tests/Producer_Produce_Async.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -69,23 +69,23 @@ public void Producer_Produce_Memory_Async(string bootstrapServers)
6969
var producerConfig = new ProducerConfig { BootstrapServers = bootstrapServers };
7070

7171
using (var testTopic = new TemporaryTopic(bootstrapServers, 1))
72-
using (var producer = new TestProducerBuilder<Null, Memory<byte>>(producerConfig)
72+
using (var producer = new TestProducerBuilder<Memory<byte>?, Memory<byte>>(producerConfig)
7373
.Build())
74-
using (var dProducer = new DependentProducerBuilder<ReadOnlyMemory<byte>, Null>(producer.Handle)
74+
using (var dProducer = new DependentProducerBuilder<ReadOnlyMemory<byte>, ReadOnlyMemory<byte>?>(producer.Handle)
7575
.Build())
7676
{
7777
Memory<byte> data = new byte[] { 1, 2, 3, 4 };
78-
Assert.Throws<ProduceException<Null, Memory<byte>>>(
79-
() => producer.Produce(testTopic.Name, new Message<Null, Memory<byte>> { Value = data }));
78+
Assert.Throws<ProduceException<Memory<byte>?, Memory<byte>>>(
79+
() => producer.Produce(testTopic.Name, new Message<Memory<byte>?, Memory<byte>> { Value = data }));
8080

81-
Assert.Throws<ProduceException<Null, Memory<byte>>>(
82-
() => producer.Produce(testTopic.Name, new Message<Null, Memory<byte>> { Value = data }, dr => { Assert.True(false); }));
81+
Assert.Throws<ProduceException<Memory<byte>?, Memory<byte>>>(
82+
() => producer.Produce(testTopic.Name, new Message<Memory<byte>?, Memory<byte>> { Value = data }, dr => { Assert.True(false); }));
8383

84-
Assert.Throws<ProduceException<ReadOnlyMemory<byte>, Null>>(
85-
() => dProducer.Produce(testTopic.Name, new Message<ReadOnlyMemory<byte>, Null> { Key = data }));
84+
Assert.Throws<ProduceException<ReadOnlyMemory<byte>, ReadOnlyMemory<byte>?>>(
85+
() => dProducer.Produce(testTopic.Name, new Message<ReadOnlyMemory<byte>, ReadOnlyMemory<byte>?> { Key = data }));
8686

87-
Assert.Throws<ProduceException<ReadOnlyMemory<byte>, Null>>(
88-
() => dProducer.Produce(testTopic.Name, new Message<ReadOnlyMemory<byte>, Null> { Key = data }, dr => { Assert.True(false); }));
87+
Assert.Throws<ProduceException<ReadOnlyMemory<byte>, ReadOnlyMemory<byte>?>>(
88+
() => dProducer.Produce(testTopic.Name, new Message<ReadOnlyMemory<byte>, ReadOnlyMemory<byte>?> { Key = data }, dr => { Assert.True(false); }));
8989
}
9090

9191
Assert.Equal(0, Library.HandleCount);

0 commit comments

Comments
 (0)