Merge pull request #100 from SpaceManiac/fix-ub-warnings

Gankra · web-flow · commit 4f681be6f3b1 · 2019-12-17T09:56:44.000-05:00
Fix mem::uninitialized UB warning
diff --git a/src/lib.rs b/src/lib.rs
@@ -1135,7 +1135,7 @@ impl<K: Hash + Eq, V, S: BuildHasher> IntoIterator for LinkedHashMap<K, V, S> {
         }
         self.clear_free_list();
         // drop the HashMap but not the LinkedHashMap
-        self.map = unsafe { mem::uninitialized() };
+        unsafe { ptr::drop_in_place(&mut self.map); }
         mem::forget(self);
 
         IntoIter {

Original file line number	Diff line number	Diff line change
`@@ -1135,7 +1135,7 @@ impl<K: Hash + Eq, V, S: BuildHasher> IntoIterator for LinkedHashMap<K, V, S> {`
`1135`	`1135`	`}`
`1136`	`1136`	`self.clear_free_list();`
`1137`	`1137`	`// drop the HashMap but not the LinkedHashMap`
`1138`		`- self.map = unsafe { mem::uninitialized() };`
	`1138`	`+ unsafe { ptr::drop_in_place(&mut self.map); }`
`1139`	`1139`	`mem::forget(self);`
`1140`	`1140`
`1141`	`1141`	`IntoIter {`