Changed two methods that were expecting to be awaitable into asynchronous calls, which also fixes the build warnings (#337)

Author: lythix

CoreWiki.Application/Articles/Search/Impl/ArticlesDbSearchEngine.cs

@@ -24,7 +24,7 @@ public async Task<SearchResultDto<ArticleSearchDto>> SearchAsync(string query, i
 			var filteredQuery = query.Trim();
 			var offset = (pageNumber - 1) * resultsPerPage;
 
-			var (articles, totalFound) = _articleRepo.GetArticlesForSearchQuery(filteredQuery, offset, resultsPerPage);
+			var (articles, totalFound) = await _articleRepo.GetArticlesForSearchQuery(filteredQuery, offset, resultsPerPage);
 
 			var result = new SearchResult<Article>
 			{

CoreWiki.Data.Abstractions/Interfaces/IArticleRepository.cs

@@ -18,7 +18,7 @@ public interface IArticleRepository : IDisposable
 
 		Task<Article> CreateArticleAndHistory(Article article);
 
-		(IEnumerable<Article> articles, int totalFound) GetArticlesForSearchQuery(string filteredQuery, int offset, int resultsPerPage);
+		Task<(IEnumerable<Article> articles, int totalFound)> GetArticlesForSearchQuery(string filteredQuery, int offset, int resultsPerPage);
 
 		Task<bool> IsTopicAvailable(string articleSlug, int articleId);
 

CoreWiki.Data/Repositories/ArticleRepository.cs

@@ -71,7 +71,7 @@ public async Task<bool> IsTopicAvailable(string articleSlug, int articleId)
 				.AnyAsync(a => a.Slug == articleSlug && a.Id != articleId);
 		}
 
-		public (IEnumerable<Article> articles, int totalFound) GetArticlesForSearchQuery(string filteredQuery, int offset, int resultsPerPage)
+		public async Task<(IEnumerable<Article> articles, int totalFound)> GetArticlesForSearchQuery(string filteredQuery, int offset, int resultsPerPage)
 		{
 			// WARNING:  This may need to be further refactored to allow for database optimized search queries
 
@@ -82,7 +82,7 @@ public async Task<bool> IsTopicAvailable(string articleSlug, int articleId)
 					|| a.Content.ToUpper().Contains(filteredQuery.ToUpper())
 				).Select(a => a.ToDomain());
 			var articleCount = articles.Count();
-			var list = articles.Skip(offset).Take(resultsPerPage).OrderByDescending(a => a.ViewCount).ToList();
+			var list = await articles.Skip(offset).Take(resultsPerPage).OrderByDescending(a => a.ViewCount).ToListAsync();
 
 			return (list, articleCount);
 		}

CoreWiki/Pages/CreateArticleFromLink.cshtml.cs

@@ -71,7 +71,7 @@ public async Task<IActionResult> OnPostCreateLinksAsync(string slug)
 				taskList.Add(_mediator.Send(createCmd));
 			});
 
-			Task.WaitAll(taskList.ToArray());
+			await Task.WhenAll(taskList.ToArray());
 
 			return Redirect($"/wiki/{(slug == UrlHelpers.HomePageSlug ? "" : slug)}");
 		}