- small fix and new option

- add another option `clearNestDescendants`
- small fix

Author: ctf0

README.md

@@ -89,7 +89,7 @@ return [
      *
      * do you want to clear its parent and make it a root ?
      */
-    'clearPartialyNestedParent'=> false,
+    'clearPartialyNestedParent'=> true,
 
     /*
      * when removing a root page from a menu, ex.
@@ -103,6 +103,11 @@ return [
      */
     'clearRootDescendants' => false,
 
+    /**
+     * when removing a nest from a list, do you want to reset its hierarchy ?
+     */
+    'clearNestDescendants' => false,
+
     /*
      * when deleteing a page "from the db", do you also want to delete all of its childrens ?
      */

src/Controllers/Admin/Traits/MenuOps.php

@@ -60,7 +60,13 @@ public function removePage($id, Request $request)
      */
     public function removeChild(Request $request)
     {
-        $this->clearSelfAndNests($request->child_id);
+        if (config('simpleMenu.clearNestDescendants')) {
+            $this->clearSelfAndNests($request->child_id);
+        } else {
+            $page = $this->findPage($request->child_id);
+            $page->makeRoot();
+            $page->touch();
+        }
 
         return response()->json(['done'=>true]);
     }

src/Traits/NavigationTrait.php

@@ -21,10 +21,15 @@ public function getUrl($code)
     {
         $name = Route::currentRouteName();
 
+        // redir to '/' if the first item in "bc" is in diff locale
+        $bc = $this->getRouteData($name)['breadCrumb'];
+        if (isset($bc) && count($bc) && !$this->searchForRoute($bc->pluck('route_name')->first(), $code)) {
+            return LaravelLocalization::getLocalizedURL($code, url('/'), [], true);
+        }
+
         // routeName is not saved in the db (ex.php artisan make:auth)
         // or only url
         $routesListFile = include $this->listFileDir;
-
         if (is_null($name) || !array_get($routesListFile, $name)) {
             return LaravelLocalization::getLocalizedURL($code, null, [], true);
         }
@@ -110,7 +115,7 @@ public function getBC()
         $name = Route::currentRouteName();
         $bc   = $this->getRouteData($name)['breadCrumb'];
 
-        if (isset($bc) && count($bc) && $this->searchForRoute($bc->pluck('route_name')->first(), $this->getCrntLocale())) {
+        if (isset($bc) && count($bc)) {
             return $bc;
         }
     }

src/config/simpleMenu.php

@@ -39,16 +39,19 @@
     'userModel' => App\User::class,
 
     /*
-     * when adding a page which is a nest of a nother to a menu
+     * when adding a page which is a nest of another to a menu
      *
      * root
      *   | child 1
-     *     | child 2 "add this along with its childrens to another menu"
+     *     | child 2 "add this along with its children to another menu"
      *       | child 3
      *
      * do you want to clear its parent and make it a root ?
+     *
+     * note that this will cause issues for breadcumb as to "what to show" and "what to hide"
+     * if set to "false"
      */
-    'clearPartialyNestedParent'=> false,
+    'clearPartialyNestedParent'=> true,
 
     /*
      * when removing a root page from a menu, ex.
@@ -63,7 +66,12 @@
     'clearRootDescendants' => false,
 
     /*
-     * when deleteing a page "from the db", do you also want to delete all of its childrens ?
+     * when removing a nest from a list, do you want to reset its hierarchy ?
+     */
+    'clearNestDescendants'=> false,
+
+    /*
+     * when deleting a page "from the db", do you also want to delete all of its children ?
      */
     'deletePageAndNests' => false,
 

src/resources/views/breadCrumb.blade.php

@@ -2,7 +2,6 @@
     <nav class="breadcrumb">
         <ul>
             @foreach ($breadCrumb as $page)
-                @break(!$page->title)
                 @include('SimpleMenu::menu.partials.r_params')
 
                 <li class="{{ SimpleMenu::isActiveRoute() ? 'is-active' : '' }}">