Skip to content
This repository was archived by the owner on Jan 3, 2023. It is now read-only.

Commit f426340

Browse files
committed
fix spatie permission cache issue
1 parent 281a4ee commit f426340

File tree

5 files changed

+15
-11
lines changed

5 files changed

+15
-11
lines changed

src/Controllers/Admin/PagesController.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use Illuminate\Http\Request;
66
use ctf0\SimpleMenu\Models\Page;
77
use Spatie\Permission\Models\Role;
8+
use Spatie\Permission\Models\Permission;
89
use ctf0\SimpleMenu\Controllers\BaseController;
910
use ctf0\SimpleMenu\Controllers\Admin\Traits\PageOps;
1011

@@ -32,7 +33,7 @@ public function index()
3233
public function create()
3334
{
3435
$roles = Role::get()->pluck('name', 'name');
35-
$permissions = $this->cache->get('spatie.permission.cache')->pluck('name', 'name');
36+
$permissions = Permission::get()->pluck('name', 'name');
3637
$menus = $this->cache->tags('sm')->get('menus')->pluck('name', 'id');
3738

3839
return view("{$this->adminPath}.pages.create", compact('roles', 'permissions', 'menus'));
@@ -71,7 +72,7 @@ public function store(Request $request)
7172
public function edit($id)
7273
{
7374
$roles = Role::get()->pluck('name', 'name');
74-
$permissions = $this->cache->get('spatie.permission.cache')->pluck('name', 'name');
75+
$permissions = Permission::get()->pluck('name', 'name');
7576
$page = $this->cache->tags('sm')->get('pages')->find($id);
7677
$menus = $this->cache->tags('sm')->get('menus')->pluck('name', 'id');
7778

src/Controllers/Admin/PermissionsController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class PermissionsController extends BaseController
1818
*/
1919
public function index()
2020
{
21-
$permissions = $this->cache->get('spatie.permission.cache');
21+
$permissions = Permission::get();
2222

2323
return view("{$this->adminPath}.permissions.index", compact('permissions'));
2424
}
@@ -60,7 +60,7 @@ public function store(Request $request)
6060
*/
6161
public function edit($id)
6262
{
63-
$permission = $this->cache->get('spatie.permission.cache')->find($id);
63+
$permission = Permission::find($id);
6464

6565
return view("{$this->adminPath}.permissions.edit", compact('permission'));
6666
}

src/Controllers/Admin/RolesController.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
use Illuminate\Http\Request;
66
use Spatie\Permission\Models\Role;
7+
use Spatie\Permission\Models\Permission;
78
use ctf0\SimpleMenu\Controllers\BaseController;
89
use ctf0\SimpleMenu\Controllers\Admin\Traits\RolePermOps;
910

@@ -30,7 +31,7 @@ public function index()
3031
*/
3132
public function create()
3233
{
33-
$permissions = $this->cache->get('spatie.permission.cache')->pluck('name', 'name');
34+
$permissions = Permission::get()->pluck('name', 'name');
3435

3536
return view("{$this->adminPath}.roles.create", compact('permissions'));
3637
}
@@ -66,7 +67,7 @@ public function store(Request $request)
6667
public function edit($id)
6768
{
6869
$role = Role::find($id);
69-
$permissions = $this->cache->get('spatie.permission.cache')->pluck('name', 'name');
70+
$permissions = Permission::get()->pluck('name', 'name');
7071

7172
return view("{$this->adminPath}.roles.edit", compact('role', 'permissions'));
7273
}

src/Controllers/Admin/UsersController.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use App\User;
66
use Illuminate\Http\Request;
77
use Spatie\Permission\Models\Role;
8+
use Spatie\Permission\Models\Permission;
89
use ctf0\SimpleMenu\Controllers\BaseController;
910

1011
class UsersController extends BaseController
@@ -29,7 +30,7 @@ public function index()
2930
public function create()
3031
{
3132
$roles = Role::get()->pluck('name', 'name');
32-
$permissions = $this->cache->get('spatie.permission.cache')->pluck('name', 'name');
33+
$permissions = Permission::get()->pluck('name', 'name');
3334

3435
return view("{$this->adminPath}.users.create", compact('roles', 'permissions'));
3536
}
@@ -70,7 +71,7 @@ public function edit($id)
7071
{
7172
$user = $this->cache->get('sm-users')->find($id);
7273
$roles = Role::get()->pluck('name', 'name');
73-
$permissions = $this->cache->get('spatie.permission.cache')->pluck('name', 'name');
74+
$permissions = Permission::get()->pluck('name', 'name');
7475

7576
return view("{$this->adminPath}.users.edit", compact('user', 'roles', 'permissions'));
7677
}

src/SimpleMenuServiceProvider.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use ctf0\SimpleMenu\Models\Menu;
66
use ctf0\SimpleMenu\Models\Page;
77
use Illuminate\Support\Facades\URL;
8+
use Illuminate\Filesystem\Filesystem;
89
use Illuminate\Support\ServiceProvider;
910
use ctf0\SimpleMenu\Observers\MenuObserver;
1011
use ctf0\SimpleMenu\Observers\PageObserver;
@@ -24,9 +25,9 @@ class SimpleMenuServiceProvider extends ServiceProvider
2425
/**
2526
* Perform post-registration booting of services.
2627
*/
27-
public function boot()
28+
public function boot(Filesystem $file)
2829
{
29-
$this->file = app('files');
30+
$this->file = $file;
3031

3132
$this->packagePublish();
3233

@@ -215,7 +216,7 @@ protected function autoReg()
215216
}
216217

217218
// run check once
218-
app('cache')->store('file')->rememberForever('ct-mm', function () {
219+
app('cache')->store('file')->rememberForever('ct-sm', function () {
219220
return 'added';
220221
});
221222
}

0 commit comments

Comments
 (0)