feat: Add string-based boolean flags for explorer-alpha parameters (#1139)

* fix boolean flags, they weren't working when the flag was =false because of the Boolean cast.
Add new -n flag to open the client in a new instance

* remvoe patch coverage check

* add tests

Author: gonpombo8

codecov.yml

@@ -3,6 +3,6 @@ coverage:
     project:
       default:
         threshold: 1%
-    patch:
+    patch: off
       default:
         threshold: 1%

packages/@dcl/sdk-commands/src/commands/start/explorer-alpha.ts

@@ -4,6 +4,12 @@ import { CliComponents } from '../../components'
 
 const isWindows = /^win/.test(process.platform)
 
+// Helper function to convert string to boolean
+function stringToBoolean(value: string | undefined, defaultValue: boolean = true): boolean {
+  if (!value) return defaultValue
+  return value.toLowerCase() === 'true'
+}
+
 export async function runExplorerAlpha(
   components: CliComponents,
   opts: {
@@ -42,23 +48,30 @@ async function runApp(
   const cmd = isWindows ? 'start' : 'open'
   const position = args['--position'] ?? `${baseCoords.x},${baseCoords.y}`
   const realm = args['--realm'] ?? realmValue
-  const localScene = args['--local-scene'] ?? true
-  const debug = args['--debug'] ?? true
+  const localScene = stringToBoolean(args['--local-scene'], true)
+  const debug = stringToBoolean(args['--debug'], true)
   const dclenv = args['--dclenv'] ?? 'org'
-  const skipAuthScreen = args['--skip-auth-screen'] ?? true
-  const landscapeTerrainEnabled = args['--landscape-terrain-enabled'] ?? true
+  const skipAuthScreen = stringToBoolean(args['--skip-auth-screen'], true)
+  const landscapeTerrainEnabled = stringToBoolean(args['--landscape-terrain-enabled'], true)
+  const openDeeplinkInNewInstance = args['-n']
 
   try {
-    const queryParams = [
-      `realm=${realm}`,
-      `position=${position}`,
-      `local-scene=${localScene}`,
-      `debug=${debug}`,
-      `hub=${isHub}`,
-      `dclenv=${dclenv}`,
-      `skip-auth-screen=${skipAuthScreen}`,
-      `landscape-terrain-enabled=${landscapeTerrainEnabled}`
-    ].join('&')
+    const params = new URLSearchParams()
+
+    params.set('realm', realm)
+    params.set('position', position)
+    params.set('local-scene', localScene.toString())
+    params.set('debug', debug.toString())
+    params.set('hub', isHub.toString())
+    params.set('dclenv', dclenv)
+    params.set('skip-auth-screen', skipAuthScreen.toString())
+    params.set('landscape-terrain-enabled', landscapeTerrainEnabled.toString())
+
+    if (openDeeplinkInNewInstance) {
+      params.set('open-deeplink-in-new-instance', openDeeplinkInNewInstance.toString())
+    }
+
+    const queryParams = params.toString()
 
     const app = `decentraland://"${queryParams}"`
     await components.spawner.exec(cwd, cmd, [app], { silent: true })

packages/@dcl/sdk-commands/src/commands/start/index.ts

@@ -53,13 +53,14 @@ export const args = declareArgs({
   '--explorer-alpha': Boolean,
   '--hub': Boolean,
   // Params related to the explorer-alpha
-  '--debug': Boolean,
+  '--debug': String,
   '--dclenv': String,
   '--realm': String,
   '--local-scene': String,
   '--position': String,
-  '--skip-auth-screen': Boolean,
-  '--landscape-terrain-enabled': Boolean
+  '--skip-auth-screen': String,
+  '--landscape-terrain-enabled': String,
+  '-n': Boolean
 })
 
 export async function help(options: Options) {
@@ -68,21 +69,22 @@ export async function help(options: Options) {
 
     Options:
 
-      -h, --help                  Displays complete help
-      -p, --port        [port]    Select a custom port for the development server
-      -d, --no-debug              Disable debugging panel
-      -b, --no-browser            Do not open a new browser window
-      -w, --no-watch              Do not open watch for filesystem changes
-      -c, --ci                    Run the parcel previewer on a remote unix server
-      --web3                      Connects preview to browser wallet to use the associated avatar and account
-      --skip-build                Skip build and only serve the files in preview mode
-      --debug                     Enables Debug panel mode inside DCL Explorer (default=true)
-      --dclenv                    Decentraland Environment. Which environment to use for the content. This determines the catalyst server used, asset-bundles, etc. Possible values: org, zone, today. (default=org)
-      --realm                     Realm used to serve the content. (default=Localhost)
-      --local-scene               Enable local scene development.
-      --position                  Initial Position to start the explorer. (default=position defined at scene.json)
-      --skip-auth-screen          Skip the auth screen.
-      --landscape-terrain-enabled Enable landscape terrain.
+      -h, --help                        Displays complete help
+      -p, --port                        Select a custom port for the development server
+      -d, --no-debug                    Disable debugging panel
+      -b, --no-browser                  Do not open a new browser window
+      -w, --no-watch                    Do not open watch for filesystem changes
+      -c, --ci                          Run the parcel previewer on a remote unix server
+      --web3                            Connects preview to browser wallet to use the associated avatar and account
+      --skip-build                      Skip build and only serve the files in preview mode
+      --debug                           Enables Debug panel mode inside DCL Explorer (default=true)
+      --dclenv                          Decentraland Environment. Which environment to use for the content. This determines the catalyst server used, asset-bundles, etc. Possible values: org, zone, today. (default=org)
+      --realm                           Realm used to serve the content. (default=Localhost)
+      --local-scene                     Enable local scene development.
+      --position                        Initial Position to start the explorer. (default=position defined at scene.json)
+      --skip-auth-screen                Skip the auth screen (accepts 'true' or 'false').
+      --landscape-terrain-enabled       Enable landscape terrain.
+      -n                                Open a new instance of the Client even if one is already running.
 
 
     Examples: