Fix windowed notebook tests to work with JupyterLab 4.2 (#125)

Author: krassowski

ui-tests/package.json

@@ -9,7 +9,7 @@
     "test:update": "jlpm playwright test --update-snapshots"
   },
   "devDependencies": {
-    "@jupyterlab/galata": "^5.1.0-rc.1",
-    "@playwright/test": "^1.32.2"
+    "@jupyterlab/galata": "^5.2.0",
+    "@playwright/test": "^1.44.0"
   }
 }

ui-tests/tests/windowed_notebook.spec.ts

@@ -5,6 +5,7 @@ const SETTINGS_ID = 'jupyterlab-execute-time:settings';
 const NOTEBOOK_ID = '@jupyterlab/notebook-extension:tracker';
 
 test.describe('Windowed notebook', () => {
+  const fileName = '100_code_cells.ipynb';
   test.use({
     mockSettings: {
       ...galata.DEFAULT_SETTINGS,
@@ -14,11 +15,21 @@ test.describe('Windowed notebook', () => {
       },
     },
   });
-  test.beforeEach(openNotebook('100_code_cells.ipynb'));
+  test.beforeEach(openNotebook(fileName));
   test.afterEach(cleanup);
 
-  test('Node attaches after scrolling into view', async ({ page }) => {
+  test('Node attaches after scrolling into view', async ({ page, tmpPath }) => {
+    // Run all cells; this will scroll us to the end
     await page.notebook.run();
+    // Select first cell
+    await page.notebook.selectCells(0);
+    await page.notebook.save();
+    // Reopen the notebook to unload the widgets attached during execution
+    await page.notebook.close(false);
+    await page.notebook.openByPath(`${tmpPath}/${fileName}`);
+    await page.notebook.activate(fileName);
+    // Wait for the notebook state to settle
+    await page.waitForTimeout(100);
     // Check that only a fraction of cells have the widget
     expect(await page.locator('.execute-time').count()).toBeLessThan(50);
     // Get the 100th cells locator without scrolling
@@ -36,6 +47,7 @@ test.describe('Windowed notebook', () => {
 });
 
 test.describe('Windowed notebook/hover', () => {
+  const fileName = '100_code_cells.ipynb';
   // The hover mode is useful for creating windowed notebook tests
   // because in this mode execution does not move the notebook window.
   test.use({
@@ -51,7 +63,8 @@ test.describe('Windowed notebook/hover', () => {
       },
     },
   });
-  test.beforeEach(openNotebook('100_code_cells.ipynb'));
+
+  test.beforeEach(openNotebook(fileName));
   test.afterEach(cleanup);
 
   test('Only one node per cell is attached when scrolling', async ({
@@ -69,6 +82,7 @@ test.describe('Windowed notebook/hover', () => {
     });
     // Count the visible cells
     const visibleCells = await page.locator('.jp-CodeCell:visible').count();
+    expect(visibleCells).toBeGreaterThan(0);
     // Wait until all visible cells have the widget
     await page
       .locator(`:nth-match(.execute-time, ${visibleCells})`)
@@ -88,7 +102,7 @@ test.describe('Windowed notebook/hover', () => {
     // The number of visible widgets should be approximately equal the number of visible cells
     // If multiple nodes were attached, the count would be equal to `3 * visibleCells`.
     expect(await page.locator(`.execute-time`).count()).toBeLessThanOrEqual(
-      visibleCells + 2
+      visibleCells + 5
     );
   });
 });