Skip to content

Commit 4db3500

Browse files
committed
build: avoid duplicated dependencies at top-level
`rules_js` seems to be sensitive if there are similar versions of the same package installed, but with differently matched peer dependencies. This is fine because we can (and should long-term) move those dependencies to their package-local `package.json` files. This commit unblocks the migration and highlights how we can move deps to the individual packages in the future.
1 parent 53a5c0e commit 4db3500

File tree

4 files changed

+4
-34
lines changed

4 files changed

+4
-34
lines changed

package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@
7777
"@eslint/compat": "1.2.7",
7878
"@eslint/eslintrc": "3.3.0",
7979
"@eslint/js": "9.21.0",
80-
"@inquirer/confirm": "5.1.6",
8180
"@inquirer/prompts": "7.3.2",
8281
"@listr2/prompt-adapter-inquirer": "2.0.18",
8382
"@rollup/plugin-alias": "^5.1.1",
@@ -111,7 +110,6 @@
111110
"@types/yarnpkg__lockfile": "^1.1.5",
112111
"@typescript-eslint/eslint-plugin": "8.26.0",
113112
"@typescript-eslint/parser": "8.26.0",
114-
"@vitejs/plugin-basic-ssl": "2.0.0",
115113
"@web/test-runner": "^0.20.0",
116114
"@yarnpkg/lockfile": "1.1.0",
117115
"ajv": "8.17.1",
@@ -204,7 +202,6 @@
204202
"unenv": "^1.10.0",
205203
"verdaccio": "6.0.5",
206204
"verdaccio-auth-memory": "^10.0.0",
207-
"vite": "6.2.1",
208205
"watchpack": "2.4.2",
209206
"webpack": "5.98.0",
210207
"webpack-dev-middleware": "7.4.2",

packages/angular/build/BUILD.bazel

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,9 @@ ts_project(
7777
":node_modules/@angular-devkit/architect",
7878
":node_modules/@angular-devkit/core",
7979
":node_modules/@angular/ssr",
80+
":node_modules/@inquirer/confirm",
81+
":node_modules/@vitejs/plugin-basic-ssl",
82+
":node_modules/vite",
8083
"//:node_modules/@ampproject/remapping",
8184
"//:node_modules/@angular/common",
8285
"//:node_modules/@angular/compiler",
@@ -89,15 +92,13 @@ ts_project(
8992
"//:node_modules/@babel/helper-annotate-as-pure",
9093
"//:node_modules/@babel/helper-split-export-declaration",
9194
"//:node_modules/@babel/plugin-syntax-import-attributes",
92-
"//:node_modules/@inquirer/confirm",
9395
"//:node_modules/@types/babel__core",
9496
"//:node_modules/@types/karma",
9597
"//:node_modules/@types/less",
9698
"//:node_modules/@types/node",
9799
"//:node_modules/@types/picomatch",
98100
"//:node_modules/@types/semver",
99101
"//:node_modules/@types/watchpack",
100-
"//:node_modules/@vitejs/plugin-basic-ssl",
101102
"//:node_modules/beasties",
102103
"//:node_modules/browserslist",
103104
"//:node_modules/esbuild",
@@ -123,7 +124,6 @@ ts_project(
123124
"//:node_modules/tinyglobby",
124125
"//:node_modules/tslib",
125126
"//:node_modules/typescript",
126-
"//:node_modules/vite",
127127
"//:node_modules/watchpack",
128128
],
129129
)

packages/angular_devkit/build_angular/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ ts_project(
135135
":node_modules/@angular/build",
136136
":node_modules/@angular/ssr",
137137
":node_modules/@ngtools/webpack",
138+
":node_modules/@vitejs/plugin-basic-ssl",
138139
"//:node_modules/@ampproject/remapping",
139140
"//:node_modules/@angular/common",
140141
"//:node_modules/@angular/compiler-cli",
@@ -162,7 +163,6 @@ ts_project(
162163
"//:node_modules/@types/picomatch",
163164
"//:node_modules/@types/semver",
164165
"//:node_modules/@types/watchpack",
165-
"//:node_modules/@vitejs/plugin-basic-ssl",
166166
"//:node_modules/@web/test-runner",
167167
"//:node_modules/ajv",
168168
"//:node_modules/ansi-colors",

pnpm-lock.yaml

Lines changed: 0 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)