Skip to content

Commit 4c4d803

Browse files
committed
cleanup assisted installer bare metal validations enhancement
fix some review comments missed before openshift#388 merged Signed-off-by: Doug Hellmann <[email protected]>
1 parent c6daad5 commit 4c4d803

File tree

1 file changed

+2
-40
lines changed

1 file changed

+2
-40
lines changed

enhancements/installer/assisted-installer-bare-metal-validations.md

Lines changed: 2 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ installer-provisioned infrastructure capabilities.
4343
The [connected-assisted-installer
4444
enhancement](./connected-assisted-installer.md) describes how an agent
4545
running on several bare-metal hosts receive a command from the
46-
assisted installer application to begin the installation of that
46+
assisted installer service to begin the installation of that
4747
host. One of the first tasks that each host performs upon receiving
4848
this instruction is to download, from the assisted installer, the
4949
appropriate Ignition file for that host's role. These ignition files
@@ -53,7 +53,7 @@ the `openshift-install create ignition-configs` command.
5353
This installer workflow mirrors the [bare-metal user-provisioned
5454
infrastructure
5555
workflow](https://github.com/openshift/installer/blob/master/docs/user/metal/install_upi.md)
56-
in that the the OpenShift installer is used to generate assets for the
56+
in that the OpenShift installer is used to generate assets for the
5757
cluster but the `openshift-install create cluster` command is not used
5858
to manage the deployment. However, the assisted installer does need to
5959
enable some `baremetal` installer-provisioned infrastructure platform
@@ -200,44 +200,6 @@ the `baremetal` platform will continue to test the full set of
200200
validation rules. The test suite for the assisted installer will
201201
verify that no extra validation rules are applied.
202202

203-
### Graduation Criteria
204-
205-
**Note:** *Section not required until targeted at a release.*
206-
207-
Define graduation milestones.
208-
209-
These may be defined in terms of API maturity, or as something else. Initial proposal
210-
should keep this high-level with a focus on what signals will be looked at to
211-
determine graduation.
212-
213-
Consider the following in developing the graduation criteria for this
214-
enhancement:
215-
- Maturity levels - `Dev Preview`, `Tech Preview`, `GA`
216-
- Deprecation
217-
218-
Clearly define what graduation means.
219-
220-
#### Examples
221-
222-
These are generalized examples to consider, in addition to the aforementioned
223-
[maturity levels][maturity-levels].
224-
225-
##### Dev Preview -> Tech Preview
226-
227-
- Ability to utilize the enhancement end to end
228-
- End user documentation, relative API stability
229-
- Sufficient test coverage
230-
- Gather feedback from users rather than just developers
231-
232-
##### Tech Preview -> GA
233-
234-
- More testing (upgrade, downgrade, scale)
235-
- Sufficient time for feedback
236-
- Available by default
237-
238-
**For non-optional features moving to GA, the graduation criteria must include
239-
end to end tests.**
240-
241203
## Implementation History
242204

243205
Major milestones in the life cycle of a proposal should be tracked in `Implementation

0 commit comments

Comments
 (0)